638164 - Checkerboarding after zooming in, visiting other page, then going back in history

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

More or less a follow-up from bug 622601.

Steps to reproduce:
- Go to http://www.nu.nl
- Scroll down
- Zoom in (either by double-tapping on pinch-zoom)
- Tap on a link
- After the resulting has loaded, go back in history

Expected result:
- The http://www.nu.nl should get shown, scrolled down at the position where you left that page. (and should the previous zoom level be restored too?)

Actual result:
- I only get to see checkerboarding or a gray area on the Android device (Droid)

Comment 1

[Martijn Wargers (dead)]

Firefox doesn't restore the zoom level, so I guess it's probably best to not restore the zoom level on Fennec, either.

Comment 2

[Martijn Wargers (dead)]

Mark Finkle mentioned on IRC this is probably related to bug 617952.

Comment 3

[Wesley Johnston (:wesj)]

Should be fixed by Bug 638170.

Comment 4

[Anna (Waverley)]

I can still reproduce it following the steps to reproduce from the bug:

I also made a video: http://www.youtube.com/user/qaioana#p/u/1/7drQ-wzXPqI

I press the system menu back button and it's still reproducing... Opening the man.

Comment 5

[Anna (Waverley)]

I forgot to mention the build id: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110316 Firefox/4.0b13pre Fennec /4.0b6pre 

Devices: Motorola Droid 2 (Android 2.2), HTC Desire (Android 2.2)

Comment 6

[Martijn Wargers (dead)]

I can't reproduce it anymore, fwiw.

Comment 7

[Martijn Wargers (dead)]

Hmm, I'm getting the checkerboarding at http://nu.nl when scrolling down to the bottom, then reloading the page. This is in portrait mode, using the Droid.

Comment 8

[Anna (Waverley)]

Well as you can see from the video I can still reproduce it, but only if I press the system back button... using the back arrow works fine...

Comment 9

[Martijn Wargers (dead)]

Ah, indeed, I can also reproduce it, when using the system back button.

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: possible patch

This patch fixes the issues in this bug and bug 638170. We need to test for other side affects

Comment 12

[Matt Brubeck (:mbrubeck)]

Comment on attachment 519931 [details] [diff] [review]
possible patch

This fixes the issue for me.  Might not be the ideal fix, but this is probably the right one to ship for 4.0.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

I think this patch regresses bug 622601.

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

Test build with patch:
http://people.mozilla.com/~mfinkle/fennec/fennec-4.0b6pre.en-US.eabi-arm.apk

Comment 15

[Martijn Wargers (dead)]

The test build fixes this bug. For me, bug 622601 is already not working, I filed a new bug for it, bug 641794.

Comment 16

[Martijn Wargers (dead)]

Ok, just did some more testing with the test build from comment 14. The test build from comment 14 fixes this bug, but I'm seeing checkerboarding for appr. 0.5s just prior before the new page has loaded.
I'm also getting a brief checkerboarding when the page gets restored into the right scroll position.

Comment 17

[Aaron Train [:aaronmt]]

Confirming that with the build above on my Milestone, on back, I am not seeing
checkerboarding and the page is scrolled to where it was left off. Albeit the
page is not zoomed. I used the 'Statiseken' link on the bottom foot at nu.nl

Comment 18

[Matt Brubeck (:mbrubeck)]

Pushed to trunk, mobile-2.0, and relbranch:

http://hg.mozilla.org/mobile-browser/rev/4244c8402767
http://hg.mozilla.org/releases/mobile-2.0/rev/fc47c4a659b1
http://hg.mozilla.org/releases/mobile-2.0/rev/4244c8402767

Comment 19

[Aakash Desai [:aakashd]]

verified FIXED on build:
    Mozilla/5.0 (Android; Linux armv7l; rv:2.1) Gecko/20110318 Firefox/4.0b13pre Fennec/4.0 ID:20110318114419

Comment 20

[Martijn Wargers (dead)]

Thanks Aakash. I can also verify that this bug has been fixed.

Comment 21

[Dão Gottwald [:dao]]

bugspam