Expose frame trust in stacks

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: ted)

Tracking

(Blocks: 2 bugs)

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
The breakpad stack walking code has the concept of how confident it is with the  current stack frame. It would be helpful when interpreting stacks if this was exposed on Socorro.

I expect that this should be done after bug 573100 is fixed.

Comment 1

8 years ago
Does it also have alternate suggestions with less degrees of confidence?
(Reporter)

Comment 2

8 years ago
(In reply to comment #1)
> Does it also have alternate suggestions with less degrees of confidence?

No, but that would be neat functionality to add. Currently we just unwalk each frame by trying the different methods in order of their reliability. It would be interesting to try a more global approach to avoid getting stuck on the wrong path and ending up in the weeds.
This will be trivial to add once bug 573100 is fixed. (In fact, this was one of the main things I wanted to expose by fixing that.)
Depends on: 573100
Component: Socorro → General
Product: Webtools → Socorro
Blocks: 907312

Comment 4

5 years ago
Ted said he'd take this soon. I asked not only for the stackwalk reason, but also whether, for each frame, we have the symbols for that frame or not. This will help with the reporting I'd like in bug 907312.
Assignee: nobody → ted
I'd like to split the symbol information out separately since that's a slightly different issue.
I have a patch, it will produce output like so:
         "frames" : [
            {
               "frame" : 0,
               "module" : "ntdll.dll",
               "module_offset" : "0xe514",
               "offset" : "0x7c90e514",
               "trust" : "context"
            },
            {
               "frame" : 1,
               "offset" : "0x4d9ffff",
               "trust" : "frame_pointer"
            },
            {
               "frame" : 2,
               "module" : "kernel32.dll",
               "module_offset" : "0xb9d6",
               "offset" : "0x7c80b9d6",
               "trust" : "scan"
            },

The possible values are "context", "cfi", "frame_pointer", "cfi_scan", "scan", "none".

Pull request coming up soon.
Created attachment 819831 [details] [review]
expose frame trust in stacks
Attachment #819831 - Flags: review?(benjamin)
I'll fix the symbol stuff in bug 431514.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
I'll file a followup on exposing this in the UI.

Updated

5 years ago
Attachment #819831 - Flags: review?(benjamin)
Blocks: 929095
Filed bug 929095 on the UI.
You need to log in before you can comment on or make changes to this bug.