638243 - Print function definition for eval in target scope (and fix warning for second argument to eval)

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, enhancement)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: comment 2]

Currently, if you enter some function name into the console, one of the following happens:
a) You're not currently debugging: The function definition is printed.
b) You're currently debugging: "[function] [class: Function]" is printed, followed by the function name, but not the definition.

I find that very annoying. If you're debugging, you often want to know what the definition of a function in the current scope is. Yes you can use .toSource() but that removes all line breaks which often makes it totally unreadable.

Attached you'll find a patch that special-cases functions in cmdEval (which is called if either you just enter something into the console or prepend it with /eval). While I was at it I removed some unused local variables and fixed the eval call in con_eval (eval only accepts one parameter now, cf. https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/eval) which used to throw a warning.

Not assigning this to myself yet since I first need a hint whether this change is acceptable in general.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 516401 [details] [diff] [review]
patch [Checkin: comment 2]

Trying someone else for review in Gijs's absence.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 516401 [details] [diff] [review]
patch [Checkin: comment 2]

http://hg.mozilla.org/venkman/rev/3cf0c028cc0a