assuming gnu make is understandable, assuming it is called gmake is not especially when one may have to pass special flags to make on their arch I'm attaching a patch to change all references to gmake (except #! lines) to use $(MAKE) instead, since its the Right Way(tm) Have a nice day :)
I checked in Myth's patch to mozilla/security/nss/Makefile. I also took the opportunity to delete the dead code in that makefile. I only checked in the patch on the main trunk of NSS (which is not used when building PSM) because the affected part of the makefile is only used when we do our NSS binary releases at iPlanet. /cvsroot/mozilla/security/nss/Makefile, revision 1.13 I also fixed another makefile in NSS with this problem: /cvsroot/mozilla/security/nss/lib/fortcrypt/Makefile, revision 1.4 I will look at the PSM makefiles tomorrow as David is going on sabbatical next week so he is now allowed to check in now :-)
Status: NEW → ASSIGNED
*** Bug 65446 has been marked as a duplicate of this bug. ***
I think you need to check in the changes to psm/Makefile.in, too. At least I had to apply them to make Mozilla build here.
Priority: -- → P2
Target Milestone: --- → 3.2
Version: 4.0 → 3.1
I noticed that Javi has checked in the patch for psm/Makefile.in, after I went under psm and fixed all the references to gmake. I'm going to attach the patch anyway that fixes the other (apparently unused) makefiles under psm.
Created attachment 23430 [details] [diff] [review] Patch to fix remaining references to gmake under psm.
Javi, please review my patch. Let me know if you still want to have the remaining references to gmake under psm fixed, or just tell me "don't bother".
I think this blocks bug 60912 because normally there isn't a "gmake" binary or symlink on Linux, so adding dependency.
r=javi, Go ahead and check this in when the mozilla tree opens. It's pretty straightforward.
I checked in my second patch to fix the remaining hardcoded gmake's in PSM makefiles.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.