Makefile.in files have gmake hard coded

RESOLVED FIXED in 3.2

Status

NSS
Libraries
P2
major
RESOLVED FIXED
18 years ago
18 years ago

People

(Reporter: Frank Belew, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
assuming gnu make is understandable, assuming it is called gmake is not
especially when one may have to pass special flags to make on their arch


I'm attaching a patch to change all references to gmake (except #! lines) to use
$(MAKE) instead, since its the Right Way(tm)

Have a nice day :)
(Reporter)

Comment 1

18 years ago
Created attachment 21344 [details] [diff] [review]
Patch to fix nss/Makefile and psm/Makefile.in

Updated

18 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
r=bryner
(Assignee)

Comment 3

18 years ago
I checked in Myth's patch to mozilla/security/nss/Makefile.
I also took the opportunity to delete the dead code in that
makefile.  I only checked in the patch on the main trunk of
NSS (which is not used when building PSM) because the affected
part of the makefile is only used when we do our NSS binary
releases at iPlanet.
/cvsroot/mozilla/security/nss/Makefile, revision 1.13

I also fixed another makefile in NSS with this problem:
/cvsroot/mozilla/security/nss/lib/fortcrypt/Makefile, revision 1.4

I will look at the PSM makefiles tomorrow as David is going on
sabbatical next week so he is now allowed to check in now :-)
Status: NEW → ASSIGNED

Comment 4

18 years ago
*** Bug 65446 has been marked as a duplicate of this bug. ***

Comment 5

18 years ago
I think you need to check in the changes to psm/Makefile.in, too.
At least I had to apply them to make Mozilla build here.
(Assignee)

Updated

18 years ago
Priority: -- → P2
Target Milestone: --- → 3.2
Version: 4.0 → 3.1
(Assignee)

Comment 6

18 years ago
I noticed that Javi has checked in the patch for psm/Makefile.in,
after I went under psm and fixed all the references to gmake.  I'm
going to attach the patch anyway that fixes the other (apparently
unused) makefiles under psm.
(Assignee)

Comment 7

18 years ago
Created attachment 23430 [details] [diff] [review]
Patch to fix remaining references to gmake under psm.
(Assignee)

Comment 8

18 years ago
Javi, please review my patch.  Let me know if you
still want to have the remaining references to
gmake under psm fixed, or just tell me "don't
bother".

Comment 9

18 years ago
I think this blocks bug 60912 because normally there isn't a "gmake" binary
or symlink on Linux, so adding dependency.
Blocks: 60912

Comment 10

18 years ago
r=javi,

Go ahead and check this in when the mozilla tree opens.  It's pretty 
straightforward. 
(Assignee)

Comment 11

18 years ago
I checked in my second patch to fix the remaining hardcoded
gmake's in PSM makefiles.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.