638356 - disco pane promo tweaks

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P2)

Description

[Justin Scott [:fligtar]]

1. at a certain width the promo turns gray: http://grab.by/9gkV

2. the personas are not centered on the white boxes; they're too far to the left

3. we should remove the title="" from the personas since hovering will be common and the title is distracting

Comment 1

[Justin Scott [:fligtar]]

Oh, and the starter add-ons aren't using our editorialized summaries. This is important because ours are more concise and are going to be localized (we can't localize the developers's content).

Comment 2

[Christopher Van Wiemeersch [:cvan]]

(In reply to comment #1)
> Oh, and the starter add-ons aren't using our editorialized summaries. This is
> important because ours are more concise and are going to be localized (we can't
> localize the developers's content).

The descriptions for the Starter Pack add-ons have already been replaced with these (per bug 636239):

1. Title: Starter Pack
Intro text: First time with Add-ons? Not to worry, here are three to get
started.
• Yoono: Easily connect to your social networks, and share or comment on the
page you're visiting. 
• Invisible Hand: A quick view to compare prices when you shop online or search
for flights.
• ImTranslator: Translate content on the web from and into over 40 languages

https://addons.allizom.org/en-US/firefox/discovery/pane/3.6/Linux

These are the correct ones, right?

Comment 3

[Justin Scott [:fligtar]]

Yeah, they weren't showing up for me before. Looks good now.

Comment 4

[Wil Clouser [:clouserw]]

(In reply to comment #0)
> 1. at a certain width the promo turns gray: http://grab.by/9gkV

Now bug 638490

Comment 5

[Christopher Van Wiemeersch [:cvan]]

(In reply to comment #0)
> 2. the personas are not centered on the white boxes; they're too far to the
> left
> 
> 3. we should remove the title="" from the personas since hovering will be
> common and the title is distracting

https://github.com/jbalogh/zamboni/commit/12d37de