638557 - Show bookmark import sources in a most > least useful order

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Reorders the import directives

Currently the pop-up that shows possible sources of bookmarks to import is ordered in a "random" way, in that things appear mostly in the order that we decided to add them in the file.  That is silly.  (It also means Safari, the best supported source of bookmarks, is buried in the middle of the list between older and more obscure browsers.)  It's bothered me for some time now while working on bookmarks import bugs, and it's a perfect "a few minutes free" patch, since it just moves the import directives around :P

This patch re-orders the list so that, if all possible sources are found, the list looks like this, with the first item selected:

* Safari
* Mozilla Firefox 2 (Fx 0.x to 2)
* OmniWeb 5
* OmniWeb 4
* Opera
* SeaMonkey 2
* Netscape/Mozilla/SeaMonkey 1.x (NS 6/7, Moz 1.x, Sm 1.x)
* iCab 3
* iCab 2 (0.x to 2.x)
* Internet Explorer

Obviously we'd like to slot in Firefox 3/4 (bug 327035) above Firefox 2, and Chrome (bug 537567) in that same general area, but given what we can import, this seems like a much more sane listing.

Comment 1

[Stuart Morgan]

Comment on attachment 516686 [details] [diff] [review]
Reorders the import directives

The whole reverse-order thing is lame, but I won't block the UI improvement here on making the code structure saner ;)
sr=smorgan

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/090426821b6b

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Stuart Morgan from comment #1)

> The whole reverse-order thing is lame, but I won't block the UI improvement
> here on making the code structure saner ;)

I apparently never filed a bug on this :( It's now bug 728122.