638587 - Disable the Linux centos MozMill builders on try server

Status: RESOLVED FIXED

(Mozilla Messaging Graveyard :: Try Server, defect)

Description

[Mark Banner (:standard8) (afk until 21st July)]

We don't need these now - Andrew has local fixes for the fedora builders, so these are now redundant.

Comment 1

[Mark Banner (:standard8) (afk until 21st July)]

I've now disabled these builders. What I've done:

Disabled the unit-tests for the Linux builders:

http://hg.mozilla.org/build/buildbot-configs/rev/d4cdcc9649c0

This disables the xpcshell/MozMill builders on the "try" unit master. sendchange is still in place for the "try-unittest" builder to work.

I've also backed out the local changes that were in buildbotcustom/misc.py that were turning xpcshell off for the Linux platform. The diffs were:

@@ -532,7 +535,10 @@
         if pf.get('enable_opt_unittests'):
             test_builders = []
             for suites_name, suites in config['unittest_suites']:
-                test_builders.extend(generateTestBuilderNames('%s opt test' % base_name, suites_name, suites))
+                if platform.find('linux') >= 0 and suites_name == 'xpcshell':
+                    pass
+                else:
+                    test_builders.extend(generateTestBuilderNames('%s opt test' % base_name, suites_name, suites))
             triggeredUnittestBuilders.append(('%s-%s-opt-unittest' % (name, platform), test_builders, config.get('enable_merging', True)))
         if config['enable_codecoverage'] and platform in ('linux',):
             weeklyBuilders.append('%s code coverage' % base_name)
@@ -1176,11 +1203,15 @@
                 suites.remove('mochitest-a11y')
 
             if pf.get('enable_opt_unittests'):
-                branchObjects['builders'].extend(generateTestBuilder(
-                    config, name, platform, "%s opt test" % pf['base_name'],
-                    "%s-%s-opt-unittest" % (name, platform),
-                    suites_name, suites, mochitestLeakThreshold,
-                    crashtestLeakThreshold))
+                if platform.find('linux') >= 0 and suites_name == 'xpcshell':
+                    pass
+                else:
+                    print >> sys.stderr, "XXX: Creating suites for %s on platform %s" % (suites_name, platform)
+                    branchObjects['builders'].extend(generateTestBuilder(
+                        config, name, platform, "%s opt test" % pf['base_name'],
+                        "%s-%s-opt-unittest" % (name, platform),
+                        suites_name, suites, mochitestLeakThreshold,
+                        crashtestLeakThreshold))
 
         if config['enable_codecoverage']:
             # We only do code coverage builds on linux right now
@@ -1346,7 +1382,10 @@
         if pf.get('enable_opt_unittests'):
             test_builders = []
             for suites_name, suites in config['unittest_suites']:
-                test_builders.extend(generateTestBuilderNames('%s opt test' % base_name, suites_name, suites))
+                if platform.find('linux') >= 0 and suites_name == 'xpcshell':
+                    pass
+                else:
+                    test_builders.extend(generateTestBuilderNames('%s opt test' % base_name, suites_name, suites))
             triggeredUnittestBuilders.append(('%s-%s-opt-unittest' % (name, platform), test_builders, True))
         if config['enable_codecoverage'] and platform in ('linux',):
             weeklyBuilders.append('%s code coverage' % base_name)

I've got builds running at the moment to verify all is still good.

Comment 2

[Mark Banner (:standard8) (afk until 21st July)]

This is now working fine.