638663 - Install button disco pane perf improvements

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P3)

Description

[Justin Scott [:fligtar]]

To make disco pane faster:

* Ensure incompatible and non-fully-reviewed add-ons never show up on disco pane
* If a promo module has only one add-on (Pick of the Month, RYF) and it's not compatible, don't show that promo module
* Replace the single install button on the disco pane (the Pick of the Month) with a Get Add-on button that links to details view
* Drop all the button JS from main pane loading

Comment 1

[Jeff Balogh (:jbalogh)]

(In reply to comment #0)
> To make disco pane faster:
> 
> * Ensure incompatible and non-fully-reviewed add-ons never show up on disco
> pane

We already do that. Anywhere it doesn't happen is a bug.

> * If a promo module has only one add-on (Pick of the Month, RYF) and it's not
> compatible, don't show that promo module

Isn't that your editorial responsibility?

> * Replace the single install button on the disco pane (the Pick of the Month)
> with a Get Add-on button that links to details view
> * Drop all the button JS from main pane loading

Why do you think this will make a big difference?

Comment 2

[Potch [:potch]]

(In reply to comment #1)
> (In reply to comment #0)
> > To make disco pane faster:
> > 
> > * Ensure incompatible and non-fully-reviewed add-ons never show up on disco
> > pane
> 
> We already do that. Anywhere it doesn't happen is a bug.
> 
> > * If a promo module has only one add-on (Pick of the Month, RYF) and it's not
> > compatible, don't show that promo module
> 
> Isn't that your editorial responsibility?
> 
The issue we run into is with Minefield, possible betas, Firefox 4-5 transitions, where editorially we've selected something that fits the current browser but not its newer/older bretheren
> > * Replace the single install button on the disco pane (the Pick of the Month)
> > with a Get Add-on button that links to details view
> > * Drop all the button JS from main pane loading
> 
> Why do you think this will make a big difference?
I imagine it would be a substantial drop in the amount of JS we load. The added benefit to this is, if we can remove the possibility of coming across an addon with any incompatibility on the disco pane, we can use a much simpler and shorter logic for the buttons, and save even more bytes served. Of course, these savings are all dwarfed by the number of images we load, something we need to work on consierably.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Can this bug be closed?

Comment 4

[Wil Clouser [:clouserw]]

Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/