Closed Bug 638736 Opened 9 years ago Closed 9 years ago

Remove the need for nsDocShell::DisplayLoadError(NS_ERROR_DOCUMENT_IS_PRINTMODE) on non-printing documents

Categories

(Core :: Printing: Setup, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file)

No description provided.
Summary: Remove the need for nsDocShell::DisplayLoadError on non-printing documents → Remove the need for nsDocShell::DisplayLoadError(NS_ERROR_DOCUMENT_IS_PRINTMODE) on non-printing documents
No longer blocks: 638709
Depends on: 638709
Attached patch patchSplinter Review
This is easy, though it has still one problem. If the original page
uses plugins and is navigated away, we can paint those.
But that is a problem we have now anyway - if the plugin is destroyed while
showing print preview or something like that.
Assignee: nobody → Olli.Pettay
Attachment #516863 - Flags: review?(roc)
We clone the document for printing now. How can it be navigated away? Does this mean that we might put a document into printing mode that isn't a static clone?

Also, are you going to remove the NS_ERROR_DOCUMENT_IS_PRINTMODE error and related code?
The cloned document isn't navigated away, but the original document.
And that navigation isn't allowed atm.
We don't put that document to printing mode, but just add a flag to
the docshell, and the patch makes it so that we add the flag just to
the print docshell.

And yes, I should remove NS_ERROR_DOCUMENT_IS_PRINTMODE.
Probably in a followup.
http://hg.mozilla.org/mozilla-central/rev/08cbeed0a63f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.