638736 - Remove the need for nsDocShell::DisplayLoadError(NS_ERROR_DOCUMENT_IS_PRINTMODE) on non-printing documents

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This is easy, though it has still one problem. If the original page
uses plugins and is navigated away, we can paint those.
But that is a problem we have now anyway - if the plugin is destroyed while
showing print preview or something like that.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We clone the document for printing now. How can it be navigated away? Does this mean that we might put a document into printing mode that isn't a static clone?

Also, are you going to remove the NS_ERROR_DOCUMENT_IS_PRINTMODE error and related code?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

The cloned document isn't navigated away, but the original document.
And that navigation isn't allowed atm.
We don't put that document to printing mode, but just add a flag to
the docshell, and the patch makes it so that we add the flag just to
the print docshell.

And yes, I should remove NS_ERROR_DOCUMENT_IS_PRINTMODE.
Probably in a followup.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/08cbeed0a63f