638937 - Crash when mixing columns, first-letter & float

Status: RESOLVED FIXED

(Core :: Layout: Floats, defect)

Description

[[e-mail]]

Attachment: Test case (tries to crash after 10 seconds)

If you style a first letter with a float style, and the paragraph starts at the bottom of a column, there is no room for the letter, and it "floats" to the next column. However the rest of the paragraph is then displayed in the bottom line! The browser can subsequently abort; I found that altering the column rules was most likely to trigger the abort.

###!!! ASSERTION: aForFrame not found in block, someone lied to us: 'isValid', file nsTextFrameThebes.cpp, line 1175
###!!! ABORT: comparing iterators over different lists: 'mListLink == aOther.mListLink', file nsLineBox.h, line 722

Comment 1

[Boris Zbarsky [:bzbarsky]]

roc, this seems like your sort of thing...

Comment 2

[Jesse Ruderman]

Attachment: testcase 2

Comment 3

[Mats Palmgren (inactive)]

Attachment: frame dump

(scroll about 60% down to see the interesting frames)

We're trying to build a text run for the text frame "N" (red) which
is the child frame of a float first-letter.
nsFirstLetterFrame::CanContinueTextRun() returns 'true' so 
FindLineContainer() walks up the ancestor to 0x7fffdcf083b8 (green),
which isn't the line container for the text frame.

This should be easily fixed by returning 'false' in
CanContinueTextRun() for a floating first-letter.

Still, there's something odd about the frame tree --
why has the float been pushed into a different block from the
text is supposed to be the first letter for?
(namely 0x7fffdcd08f68 (yellow))

That seems wrong, but maybe we're not done reflowing yet?

Comment 4

[Mats Palmgren (inactive)]

Attachment: fix + tests

Try results pending:
https://tbpl.mozilla.org/?tree=Try&rev=6f52d96cba0f

Comment 5

[Mats Palmgren (inactive)]

Hmm, it appears text-transform:capitalize assumes that the start of a text run
is also the start of a word?
https://tbpl.mozilla.org/?tree=Try&rev=6f52d96cba0f
(Reftest layout/reftests/bugs/431341-1.html)

Comment 6

[Mats Palmgren (inactive)]

Looking at the text-run / line-breaker code it looks hard to get things right
when a word is broken into two text-runs.  I'll see if I can make BuildTextRuns
deal instead.

Comment 7

[Mats Palmgren (inactive)]

Attachment: fix + tests

For floating first-letter text, I think the correct line-container to use
for the line iterators here is the parent of the placeholder frame.
We've just assumed that the floating first-letter parent is the same
as the placeholder parent.  I think that's actually a bug when it's not,
but let's fix this crash first and then file a second bug on that.

The last two hunks fixes compile warnings - an unused variable and a
signed/unsigned int comparison.

The assert(18) are all "Computed overflow area must contain frame bounds"
due to the "margin: -562949953421311em;" in the test causing nscoord
overflows.  I'm not worried about that.

Comment 8

[Mats Palmgren (inactive)]

The Try run:
https://tbpl.mozilla.org/?tree=Try&rev=78f2975c3fa5

Comment 9

[Mats Palmgren (inactive)]

Filed bug 729352 to follow-up on the misplaced float first-letter frame.

Comment 10

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0edd2447ab9b

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0edd2447ab9b