638964 - Allow customization of formatting toolbar in Mail Composition

Status: ASSIGNED

(Thunderbird :: Message Compose Window, defect)

Description

[Ian Neal]

Attachment: Toolbaritems and style changes patch v1.0

At the moment the formatting toolbar in the mail composition window is not customisable.

This first patch does some preparation work by:
1/ moving those elements that are not toolbarbuttons into toolbaritems.
2/ moving from using the toolbar id to apply the style to the elements to using a class.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 517031 [details] [diff] [review]
Toolbaritems and style changes patch v1.0

Looks pretty good to me on initial review.  And in general the concept sounds fine.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 517031 [details] [diff] [review]
Toolbaritems and style changes patch v1.0

Unfortunately this has suffered some bitrot so I can't test it. Could you attach a fresh patch? Thanks

Comment 3

[Ian Neal]

Attachment: Toolbaritems and style changes patch v1.0a [Checked in: Comment 4]

Unbitrotted, carrying forward ui-r+

(I probably bitrotted myself)

Comment 4

[Ian Neal]

Comment on attachment 521787 [details] [diff] [review]
Toolbaritems and style changes patch v1.0a [Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/192dd0ddf4a5

Comment 5

[Ludovic Hirlimann [:Usul]]

Why isn't this bug closed fixed ?

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #5)
> Why isn't this bug closed fixed ?

Because you can't yet customise the toolbar - it only did the first round of style changes so far.