639193 - restore on startup loses lightning tabs because of another addon with "TypeError: Components.classes['[e-mail]/clippings;1'] is undefined"

Status: RESOLVED WORKSFORME

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Wayne Mery (:wsmwk)]

I've encountered a situation where tab restore on startup loses lightning tabs. Not using lightning long and I don't normally do lots in tabs, so I don't know if this is tabs issue, a restore, a core issue or calendar.

1. install calendar
2. install https://addons.mozilla.org/en-US/thunderbird/addon/clippings/ and force compatibility
3. open tabs for a folder, a message, add-ons, and calendar or tasks
4. restart
5. from am clippings problem you'll get "TypeError: Components.classes['[e-mail]/clippings;1'] is undefined"
6. click OK

actual results: calendar tabs are missing, other tabs are there

expected results: all tabs are restored

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Does clippings provide a tab monitor or tab type implementation? I remember an issue I temporarily had with Lightning where an exception occurring in one of those methods caused more chaos even outside of Lightning.

Comment 2

[Wayne Mery (:wsmwk)]

(In reply to comment #1)
> Does clippings provide a tab monitor or tab type implementation? 

unknown. 

I found a newer version 3.1.4 of clippings (about 1 month old - don't know why it hadn't updated) and it doesn't causes the error that version 3.1.2 does.

however, the issue remains that an add-on shouldn't cause pain for thunderbird tabs.

Comment 3

[Ludovic Hirlimann [:Usul]]

Does this needs to be moved to lightning ?

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Looks to me more like this is an issue with the clippings addon, where Thunderbird could be more robust when it comes to checking for exceptions.

Comment 5

[alta88]

This is almost certainly no longer valid after Bug 1358906.  In fact, all of these "tabs/windows aren't restored" bugs should be closed unless provable in Tb55 or later.  Aside from compose window, which was never implemented.  See also Bug 1409457 comment 10.