639301 - Update testGoogleSuggestions to work with all locales of Firefox

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Google doesn't show search suggestions for some locales, especially for those which need an input helper. For those locales we have to set 'intl.accept_languages' to 'en-us' to override the behavior and force Google to show up the English version.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1 [checked-in]

Patch to fix this failure. A test report with the af locale can be seen here:

http://mozmill-crowd.brasstacks.mozilla.com/#/general/report/f179c276497eff82ec93f78b1e227e80

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 517254 [details] [diff] [review]
Patch v1 [checked-in]

Ups, wanted to ask review from Geo.

Comment 3

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 517254 [details] [diff] [review]
Patch v1 [checked-in]

Code looks fine. As long as you're sure the strategy of essentially forcing everything to English is OK, r+ from me.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 517254 [details] [diff] [review]
Patch v1 [checked-in]

There is no other way for us at the moment. We will definitely have to revert it, once we have a local test case which works via XHR.

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/cd3d08d626d3 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/2495601a00d0 (2.0)

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Backport

Comment 6

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 517461 [details] [diff] [review]
Backport

Looks fine! r+

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/ed40e75dea4a (1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/a9089486ecb3 (1.9.1)