639321 - "Binary File" not translated

Status: NEW

(Firefox :: File Handling, defect)

Description

[Debeet]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12

Since the dawn of history string "Binary File" in dialog which you get after trying to download an executable in Firefox is not translated. Screen attached.

Reproducible: Always

Steps to Reproduce:
1. Try to download an executable.
2. In the file type you can see untranslated "Binary File".
Actual Results:  
Untranslated string

Expected Results:  
"Binary File" should be localized

Comment 1

[Debeet]

Attachment: Screenshot of the problem

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

What language are you using?

Comment 3

[Debeet]

Polish

Comment 4

[Ed Morley [:emorley]]

Marking new per screenshot

Comment 5

[Adrian Kalla [:adriank]]

that's a string which comes from the OS or server. Nothing we can do about it.
Closing as INVALID.

Comment 6

[Debeet]

How come the OS with Polish language return English "Binary File" string?

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

It is not the user's operating system. It is the server that is sending the file.

Comment 8

[Debeet]

I don't know if this is used in the actual Firefox but...
http://mxr.mozilla.org/mozilla2.0/source/uriloader/exthandler/nsExternalHelperAppService.cpp#561

I REOPEN this bug, if you think that I shouldn't - sorry.

Comment 9

[Debeet]

"These entries also ensure that we provide a good descriptive name when we encounter files with these content types and/or extensions."

Comment 10

[Adrian Kalla [:adriank]]

(In reply to comment #8)
> I don't know if this is used in the actual Firefox but...
> http://mxr.mozilla.org/mozilla2.0/source/uriloader/exthandler/nsExternalHelperAppService.cpp#561
> 
> I REOPEN this bug, if you think that I shouldn't - sorry.

even if the strings come from there, which I doubt, there is no way we could localize them -> back to the previous component.

Comment 11

[Debeet]

Can anybody that knows Firefox' code well say if that's the case (comment #8) and is there any way to let the translators localize it?

Comment 12

[Justin Dolske [:Dolske]]

The exthandler code is a bit of a mess to trace through, but I'd suspect that is indeed the source of the string that's being displayed. And the code should probably thus be changed to allow localizing those.

Comment 13

[Debeet]

I presume this won't be taken care of before 4.0 ships?

Comment 14

[Boris Zbarsky [:bzbarsky]]

Correct.

The code linked to in comment 8 is probably the right thing.  At the same time, making that stuff localizable could hurt performance in some cases...

I'd be happy to review a patch that makes those localizable and shows no perf impact.