Closed Bug 639369 Opened 13 years ago Closed 13 years ago

[OS/2] Update packaging for mozilla-central and comm-central

Categories

(Firefox Build System :: General, defect)

Other Branch
x86
OS/2
defect
Not set
normal

Tracking

(blocking2.0 Macaw+, status2.0 .1-fixed)

RESOLVED FIXED
mozilla5
Tracking Status
blocking2.0 --- Macaw+
status2.0 --- .1-fixed

People

(Reporter: dragtext, Assigned: dragtext)

Details

Attachments

(3 files)

These patches accommodate changes in our build environment:
- add *.xqs to the files copied to the packaging directory
- set the 'X' option for zip.exe to prevent extended attributes from being packaged
- run lxlite only once with all possible parameters specified and let it recurse through the packaging tree looking for *.exe and *.dll

The icon corruption that occurs when exe's are compressed is now known to be caused by overly large icon files.  This issue should be addressed in a separate bug as it doesn't directly involve packaging.

BTW.. please correct the Product and Component selections if they are incorrect.
Attachment #517299 - Flags: review?(wuno)
Attachment #517301 - Flags: review?(wuno)
Attachment #517299 - Flags: review?(wuno) → review+
Attachment #517301 - Flags: review?(wuno) → review+
Comment on attachment 517299 [details] [diff] [review]
update OS/2 packaging for mozilla-central

All ifdefed for OS/2 or in OS/2 only files. Risk is more or less zero for tier_1 platforms
Attachment #517299 - Flags: approval2.0?
Comment on attachment 517299 [details] [diff] [review]
update OS/2 packaging for mozilla-central

Approved for the mozilla2.0 repository, a=dveditz for release-drivers
Attachment #517299 - Flags: approval2.0? → approval2.0+
blocking2.0: --- → Macaw
status2.0: --- → wanted
Assignee: nobody → dragtext
Keywords: checkin-needed
Whiteboard: att517299 m-c and mozilla-2.0
(In reply to comment #2)
> Created attachment 517301 [details] [diff] [review]
> update OS/2 packaging for comm-central

Callek, how can I get approval for c-c for this patch? I couldn't find a proper flag?
Comment on attachment 517301 [details] [diff] [review]
update OS/2 packaging for comm-central

(In reply to comment #5)
> (In reply to comment #2)
> > Created attachment 517301 [details] [diff] [review]
> > update OS/2 packaging for comm-central
> 
> Callek, how can I get approval for c-c for this patch? I couldn't find a proper
> flag?

maybe feedback will be helpful?
Attachment #517301 - Flags: feedback?(bugspam.Callek)
Comment on attachment 517301 [details] [diff] [review]
update OS/2 packaging for comm-central

rs=me, you don't need approval for comm-central. See the SeaMonkey2.1 tree and Mirimar tree on tinderbox for tree status.

(Orange on SeaMonkey is ignorable, red is not)

If this needs to land in comm-1.9.2 or comm-1.9.1 please request approval.
Attachment #517301 - Flags: feedback?(bugspam.Callek) → feedback+
Status: NEW → ASSIGNED
Whiteboard: att517299 m-c and mozilla-2.0 → att517299 m-c and mozilla-2.0, att517301 c-c
The patch doesn't apply cleanly on trunk any more.
Whiteboard: att517299 m-c and mozilla-2.0, att517301 c-c → att517301 c-c
Sorry for the trouble, the older m-c patch is still needed for 2.0
Whiteboard: att517301 c-c → att524285 m-c, att517299 mozilla-2.0, att517301 c-c
http://hg.mozilla.org/mozilla-central/rev/047b8f3d5e67
Whiteboard: att524285 m-c, att517299 mozilla-2.0, att517301 c-c → att517299 mozilla-2.0, att517301 c-c
Target Milestone: --- → mozilla2.2
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/2fffeac3941c

Leaving open for Mozilla-2.0
Whiteboard: att517299 mozilla-2.0, att517301 c-c → att517299 mozilla-2.0
resolved fixed on trunk, mozilla-2.0 status is tracked in the "status2.0" custom field (which should be set to ".1-fixed" when this lands today.

It is landing today, right? code-freeze for "Macaw" is tomorrow.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
(In reply to comment #12)
> It is landing today, right? code-freeze for "Macaw" is tomorrow.

If it hasn't landed by 10pm EDT I'll land for the OS/2 folks when I get home tonight. That way it makes macaw freeze
(In reply to comment #14)
> http://hg.mozilla.org/releases/mozilla-2.0/rev/eade0686131a

Thank you!
Status: RESOLVED → UNCONFIRMED
blocking2.0: Macaw+ → ---
Ever confirmed: false
Keywords: checkin-needed
Resolution: FIXED → ---
Whiteboard: att517299 mozilla-2.0
Target Milestone: mozilla2.2 → ---
Version: Trunk → Other Branch
oops
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
blocking2.0: --- → Macaw+
Target Milestone: --- → mozilla5
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: