63951 - one pixel of cruft left after deleting an 'f' in composer

Status: VERIFIED FIXED

(Core Graveyard :: GFX, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Open Composer.
2. Make sure you're using Times New Roman 12 (this is the default font).
3. Type an 'f' and then a space.
4. Backspace the 'f' or delete a character before the 'f'.

Result: one pixel of the 'f' isn't removed until another window covers that 
portion of the Composer window.

Notes:

- 'f' is the only lower-case letter with this problem.  No upper-case letters 
have this problem.

- When you first type an 'f', the problematic black pixel isn't displayed in 
Mozilla (but it is in Wordpad).  In programs, the problematic pixel is one 
column to the right of the right side of insertion point.

Comment 1

[Kevin McCluskey (gone)]

Set target milestone to mozilla1.0.1

Comment 2

[Kevin McCluskey (gone)]

Clearing milestone.

Comment 3

[Kevin McCluskey (gone)]

Attachment: Patch to invalidate 1 extra pixel on text fields to eliminate round off error which leaves cruft

Comment 4

[Kevin McCluskey (gone)]

Setting milestone to mozilla0.9

Comment 5

[Kevin McCluskey (gone)]

The patch for this bug is really a bit of a hack. We should probably solve the
general problem, but it's probably too big of a problem to solve quickly, so I
have filed a new bug for the general problem bug 71523 and I will check in the
patch in this bug shortly.

Comment 6

[Kevin McCluskey (gone)]

Attachment: new patch with more comments

Comment 7

[Marc Attinasi]

Very nice comment and hack, er, fix. Thanks Kevin!
[s]r=attinasi

Comment 8

[karnaze (gone)]

r=karnaze. I wonder if this would be fixed if text frames always returned sizes 
aligned on pixel boundaries (if they aren't doing so now). I have seen cases 
where block's don't.

Comment 9

[Marc Attinasi]

Chris, I have a bug on the pixel-alignment issue: bug 71523

Comment 10

[Kevin McCluskey (gone)]

Fix checked in.

Comment 11

[Chris Petersen]

Marking verified per last comments.