639615 - Add-on 'Download Statusbar' fails validation in preview

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Download the add-on from https://addons.mozilla.org/en-US/firefox/addon/download-statusbar/
2. Upload the add-on in preview


observed behavior:
Validation fails with 'Addon missing install.rdf'. See https://addons.allizom.org/en-US/developers/upload/a558f7c4bf604a7694378d10cbb46a0d

Validator is expecting an install.rdf for downbarPackage.jar

Comment 1

[krupa raj[:krupa]]

Also, validation passes in prod

Comment 2

[Wil Clouser [:clouserw]]

Is this something that just landed on preview?

Comment 3

[Wil Clouser [:clouserw]]

Sounds like it's looking for install.rdf in nested packages now

Comment 4

[Wil Clouser [:clouserw]]

matt, have you looked at this?  Is it an easy fix?

Comment 5

[Matt Basta [:basta]]

It's fixed by this:

https://github.com/mozilla/amo-validator/pull/3

Comment 6

[Matt Basta [:basta]]

Fixed:

https://github.com/mozilla/amo-validator/commit/fe0df3a435f00be3f6ec2206bf7eb7870b1f176a

Comment 7

[krupa raj[:krupa]]

Attachment: test file

Download Statusbar passes validation but this is not fixed for other add-ons.

STR:
1. Upload the attached mobile add-on.

Validation fails.

https://addons.allizom.org/en-US/developers/upload/819e3af9475d44b78cf67650fd1b1e58

Comment 8

[Wil Clouser [:clouserw]]

This sounds important and makes me a little nervous since it works for one add-on but fails the next.  Let us know what you find out.

Comment 9

[Matt Basta [:basta]]

Found the problem; it was caused because the new resource I created in the error bundler was not being set properly. I fixed it and added some unit testing.

https://github.com/mozilla/amo-validator/pull/5

Comment 10

[Wil Clouser [:clouserw]]

ok, will try to get in to this push

Comment 11

[krupa raj[:krupa]]

(In reply to comment #10)
> ok, will try to get in to this push

yay!

Comment 12

[Matt Basta [:basta]]

Fixed

https://github.com/mozilla/amo-validator/commit/85bba7c1889dcc25a3edd8b2377561c96e307d1b

Comment 13

[krupa raj[:krupa]]

verified @ https://addons.allizom.org/en-US/developers/upload/9164f405fab7475491ada1fd5db1a129