639665 - Sections/features missing from review detail page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[krupa raj[:krupa]]

Compare https://addons.allizom.org/en-US/editors/review/128127?num=17#review-files to https://addons.allizom.org/z/en-US/editors/review/128127?num=17#review-files


The following sections/ features are missing on the review detail page:

* Link to Validation results with a link to help
* Flags section
* Files with a link to view contents (https://addons.allizom.org/en-US/firefox/files/browse/112585/1)
* Admin features like 'Edit Item'
* Editor Comments with a link to start a new thread
* Link to the add-on's public listing(Item overview)
* Notes to reviewer

Nit picks:

Let me know if you need me to break this into individual bugs or provide more info.
* '-' is missing between compatibility range below Apps

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

> * Link to Validation results with a link to help

Need.

> * Flags section

Don't need.

> * Files with a link to view contents
> (https://addons.allizom.org/en-US/firefox/files/browse/112585/1)

Need.

> * Admin features like 'Edit Item'

Nice to have.

> * Editor Comments with a link to start a new thread

Don't need.

> * Link to the add-on's public listing(Item overview)

Nice to have.

> * Notes to reviewer

Need.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

A couple more nits in this page:

* The review history is backwards. The newer versions should appear at the bottom.
* The Action column is redundant. It should be trimmed so that it only includes the actual action, like "Given preliminary review".

If the new review page is going to be pushed on 6.0.1, then this bug must absolutely block that release. The "Need" items on Comment 1 are critical.

Comment 3

[Gregory Koberger (:gkoberger)]

Jorge- what do you mean by "The Action column is redundant.  Trim to only show actual action"?

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

The Action column in the Item History section has redundant information. The add-on name should be obvious from the page where we're at, and the version number is already stated on the first column, so the only thing that matters is the action text ("Approved", "Rejected", "Escalated", etc.).

Comment 5

[Gregory Koberger (:gkoberger)]

> * Link to Validation results with a link to help

Done (Need.)

> * Flags section

Skipped (Don't need.)

> * Files with a link to view contents
> (https://addons.allizom.org/en-US/firefox/files/browse/112585/1)

Done (Need.)

> * Admin features like 'Edit Item'

Done (Nice to have.)

> * Editor Comments with a link to start a new thread

Skipped (Don't need.)

> * Link to the add-on's public listing(Item overview)

Skipped (Nice to have.)

> * Notes to reviewer

Didn't do this; I'm going to file another bug for it. (Need.)

> * The review history is backwards. The newer versions should appear at the
bottom.

Done.

* The Action column is redundant. It should be trimmed so that it only includes
the actual action, like "Given preliminary review".

Skipped, since we don't have this information. (We use the ActivityLog, and that uses strings.)

https://github.com/jbalogh/zamboni/commit/a3ccfa36ddedc1adf4b5b7fa37bded1eeec65265

If there's anything I skipped that you actually want, just file a bug and put it in the next milestone :)

Comment 6

[krupa raj[:krupa]]

√ Link to Validation results with a link to help @ https://addons.allizom.org/z/en-US/developers/addon/mldonkey-protocol-handler/file/24393/validation

√ Files with a link to view contents @ https://addons.allizom.org/en-US/firefox/files/browse/24393/1

√ Admin features like 'Edit Item'

I couldn't verify the Item History issue but most entries seem to be dupes. Filed bug 643780

I marking this bug verified. New issues will be filed as separate bugs.