Closed
Bug 639676
Opened 14 years ago
Closed 14 years ago
Add ability to do external links in the sidebar navigation
Categories
(Cloud Services :: Server: Account Portal, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: telliott, Assigned: telliott)
References
Details
Attachments
(1 file)
|
1.66 KB,
patch
|
jrconlin
:
review+
|
Details | Diff | Splinter Review |
Atoll suggested that we might have external links to things like SUMO in the left-hand nav. That nav is dynamically generated, so I propose that if the url starts with http in the map that we treat it as a specified URL rather than a link to build.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #517597 -
Flags: review?(jrconlin)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 517597 [details] [diff] [review]
links http urls in the mapping file externally
reviewed. Looks good.
Attachment #517597 -
Flags: review?(jrconlin) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Committed, because my hg fu is terrible in http://hg.mozilla.org/services/account-portal/rev/fc3928a0addc
|
|
Assignee | |
Comment 4•14 years ago
|
||
Wow, my hg fu is so bad that I even get it wrong when I do it right. Actual commit is http://hg.mozilla.org/services/account-portal/rev/75f5d242eee4
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•