639805 - Add default button style

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Piotr Zalewa [:zalun]]

Add default modal button style.
This is the button which callbeck will be called after hiting [Enter]

Comment 1

[Piotr Zalewa [:zalun]]

Attachment: Cancel button alone (closeModal)

Comment 2

[Piotr Zalewa [:zalun]]

Attachment: Cancel and Save buttons next to each other

Comment 3

[Piotr Zalewa [:zalun]]

Attachment: Cancel, normal and default buttons

Comment 4

[Piotr Zalewa [:zalun]]

Do you like the colors in attachments?

Comment 5

[Sean McArthur [:seanmonstar]]

I'm not sure about the cancel button being red. What about a prompt like 'Remove this file? Are you sure? There's no undo.' and then the Remove button is green?

I'm kind of thinking that positive buttons we want people to click should be green, and buttons that could be damaging should be red.

Plus, those shades seem very similar, is contrast different enough for color blind users?

Comment 6

[Piotr Zalewa [:zalun]]

I've added the "irreversible" switch which at the moment only adds the "irreversible" className. Check how this works in "delete addon" feature

https://github.com/mozilla/FlightDeck/commit/8a4c0f25eab6069208a8c18e4225d41bb9236452