639819 - The webpage doesn't repaint after the Refresh button is tapped and the page was zoomed in

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Cristian Nicolae (:xti)]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12
Build Identifier: 

The webpage doesn't reload corectly if it was before zoomed in.

Reproducible: Always

Steps to Reproduce:
1. Open Fennec App
2. Browse to www.mozilla.com/en-US/firefox/features
3. Double tap on any part of the page
4. Tap on Refresh button
Actual Results:  
After the Refresh button was pressed, the webpage doesn't redraw (the checkerboard is present all over the screen). The webpage redraws only if it is scrolled up/down.

Expected Results:  
The page reloads and it is repainted completely.

Build id : Mozilla/5.0 (Maemo;Linux armv7l;rv:2.0b13pre)Gecko/20110308
Firefox/4.0b13pre Fennec /4.0b6pre
Device: Sony Ericsson Xperia X10
OS: Android 2.1 update 1

Comment 1

[Wesley Johnston (:wesj)]

Attachment: QuickFix Patch

Here's a quickfix patch. We apparently try to catch this situation here for some cases, but are missing this one. I'd like to find a cleaner place to handle refreshes though.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 517765 [details] [diff] [review]
QuickFix Patch

Vivien, do you have any thoughts about this?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 517765 [details] [diff] [review]
QuickFix Patch

Add a comment explaining which cases we're trying to fix (we do not call tab.resetZoomLevel(); when the url is the same)

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

By the way I think this should block

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Patch with comment

Same thing with a comment.

Should have made that a review request before, but asking for one now (with comment). Sorry :(

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 517790 [details] [diff] [review]
Patch with comment

Wrong patch...arrr

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Real patch

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 517791 [details] [diff] [review]
Real patch

Looks good for now but i would like to enhance this code after the release to not have those exceptions here.

I have removed the updateCacheViewport call in the MozScrolledAreaChanged handler of chrome/content/bindings/browser.xml for bug 622601 which seems to be the root cause for why we need those calls.

Do you mind opening a followup for that?

Comment 9

[Wesley Johnston (:wesj)]

Filed Bug 639905.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

This seems bad enough to land for final release

Comment 11

[Wesley Johnston (:wesj)]

pushed: http://hg.mozilla.org/mobile-browser/rev/d3a230d749f5

Comment 12

[Anna (Waverley)]

VERIFIED FIXED on
 
Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110315 Firefox/4.0b13pre Fennec /4.0b6pre 

Device: Sony Ericsson Xperia X10 (Android 2.1 update 1)