Closed Bug 639819 Opened 11 years ago Closed 11 years ago
The webpage doesn't repaint after the Refresh button is tapped and the page was zoomed in
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12 Build Identifier: The webpage doesn't reload corectly if it was before zoomed in. Reproducible: Always Steps to Reproduce: 1. Open Fennec App 2. Browse to www.mozilla.com/en-US/firefox/features 3. Double tap on any part of the page 4. Tap on Refresh button Actual Results: After the Refresh button was pressed, the webpage doesn't redraw (the checkerboard is present all over the screen). The webpage redraws only if it is scrolled up/down. Expected Results: The page reloads and it is repainted completely. Build id : Mozilla/5.0 (Maemo;Linux armv7l;rv:2.0b13pre)Gecko/20110308 Firefox/4.0b13pre Fennec /4.0b6pre Device: Sony Ericsson Xperia X10 OS: Android 2.1 update 1
Status: UNCONFIRMED → NEW
Ever confirmed: true
Here's a quickfix patch. We apparently try to catch this situation here for some cases, but are missing this one. I'd like to find a cleaner place to handle refreshes though.
Assignee: nobody → wjohnston
Comment on attachment 517765 [details] [diff] [review] QuickFix Patch Vivien, do you have any thoughts about this?
Attachment #517765 - Flags: feedback?(21)
Comment on attachment 517765 [details] [diff] [review] QuickFix Patch Add a comment explaining which cases we're trying to fix (we do not call tab.resetZoomLevel(); when the url is the same)
Attachment #517765 - Flags: feedback?(21) → feedback+
By the way I think this should block
tracking-fennec: --- → ?
Same thing with a comment. Should have made that a review request before, but asking for one now (with comment). Sorry :(
Comment on attachment 517790 [details] [diff] [review] Patch with comment Wrong patch...arrr
Comment on attachment 517791 [details] [diff] [review] Real patch Looks good for now but i would like to enhance this code after the release to not have those exceptions here. I have removed the updateCacheViewport call in the MozScrolledAreaChanged handler of chrome/content/bindings/browser.xml for bug 622601 which seems to be the root cause for why we need those calls. Do you mind opening a followup for that?
Attachment #517791 - Flags: review?(21) → review+
Filed Bug 639905.
This seems bad enough to land for final release
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
VERIFIED FIXED on Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110315 Firefox/4.0b13pre Fennec /4.0b6pre Device: Sony Ericsson Xperia X10 (Android 2.1 update 1)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.