639831 - Expand the usefulness of tree info - allow non-google calendars and give links to pushlogs

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Mark Banner (:standard8)]

I'm kinda covering two issues here.

The simplest one is that sometimes I'm in tbpl and I want to go and check something out on the actual hmo pushlog maybe heading towards the graph. At the moment there's no easy route to do this - I have to click a revision link (if available on display), then go some convoluted route to getting to the tip/default before I can do what I want.

The easiest way to fix that is for the tree info to include links to the appropraite repositories. Therefore I've added an "otherRepo" to the list of things that can be specified on a repository and hooked both primaryRepo and otherRepo up to be displayed on tree info.


The second thing I want to fix is the google calendar - Thunderbird doesn't have one and isn't likely to get one in the short term. Therefore supply a new option in the config (currently global to the tbpl instance) to not get the google calendar, but to get the "sheriff" and "releng" divs from the tree status and display that information instead. This gives us the necessarily flexibility to be able to change it.

You can currently test this on the Thunderbird tree.

Comment 1

[Mark Banner (:standard8)]

Attachment: Proposed fix

This depends on the patch in bug 639828

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 517742 [details] [diff] [review]
Proposed fix

+    // This returns early if we're not using the google calendar.
+    if (!Config.useGoogleCalendar) {
+      var sheriff = document.getElementById("current-sheriff");
+
+      return;
+    }

unused sheriff variable

Comment 3

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/e2d5746faf47

Comment 4

[Markus Stange [:mstange]]

Deployed.