Closed Bug 639846 Opened 13 years ago Closed 11 years ago

[th] Search engine setup for Firefox Mobile for Thai.

Categories

(Mozilla Localizations :: th / Thai, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Assigned: pittaya)

References

()

Details

(Keywords: productization)

Attachments

(1 file)

We want to ship Firefox Mobile with a good list of search engines for Thai. 

We're going to work towards this in three phases. First, the localization team and the l10n drivers will look at the market for the language and come up with a good set of search providers. Patipat, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Mobile/Productization>. 

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:

> Google (mobile version), Amazon, Twitter, Wikipedia (mobile version)

Once we decide to use a particular search engine (and we test it on a mobile device), l10n drivers will contact the owner and ask for permission, and for specifics like proper search flags. Patipat, we'll likely need your help to at least get the contact information.

For search engines that we already ship with on desktop and that you would like to include in mobile as well, the permission is not needed.  Consider using a mobile version of the engine if one is available.  Also, please make yourself familiar with instructions regarding the <Description/> element at <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions>.

Finally, once we have a specification on what the search engines for Thai should look like, the localization team and the l10n drivers will work on the implementation. This should happen by the localization team creating and attaching patches for the desired changes, and requesting review from sethb@moz. After a successful review, the localization team will land them.

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Seth, Stas, Axel or someone else appointed by the l10n drivers. The data here is sensitive to users and our search partners, thus the extra care here.

We currently have en-US content in hg, I'll take the sign-off for beta with that.
Since Google is the dominated search engine we should keep them.

Amazon is somehow not very much useful here in Thailand, therefore we can remove them.

Twitter and Wikipedia (th.wikipedia.org) are useful.
Assignee: nobody → pittaya
Attached patch th_patch.diffSplinter Review
Here's the patch. We decided to have the following search engines:

> Google, Twitter, Thai Wikipedia

Amazon is not that useful in Thailand and we have no alternatives, so we decided to remove it.
Comment on attachment 813828 [details] [diff] [review]
th_patch.diff

Flagging flod for review.
Attachment #813828 - Flags: review?(francesco.lodolo)
Comment on attachment 813828 [details] [diff] [review]
th_patch.diff

Review of attachment 813828 [details] [diff] [review]:
-----------------------------------------------------------------

Patch applies cleanly, and searchplugin's structure is correct.

You can test your searchplugin here
http://l10n.mozilla-community.org/~flod/testsp/

Please commit this patch referencing the bug and the review (e.g. "Bug 639846: [th] Search engine setup for Firefox Mobile for Thai, r=flod").

I think there's something funny on Wikipedia's side though: your xml file has the same structure of English. On a phone everything works great, on a tablet the result page appears briefly and then it's redirected to a mobile website with the wrong search term (like searchterm?wasRedirected=true). 
I think it's worth it trying to notify them of this problem (it doesn't happen for English or Italian on the same device). Can you try and see if you can reproduce it?
Attachment #813828 - Flags: review?(francesco.lodolo) → review+
I can also reproduce the wikipedia issue on my tablet.
(In reply to Pittaya Sroilong from comment #5)
> I can also reproduce the wikipedia issue on my tablet.

Was this patch landed? we're getting dangerously close to the end of this cycle...
Flod, would you mind commiting this patch please? Pittaya doesn't have commit access and Patipat has been unresponsive for days. I'm asking on Pittaya's behalf.
I committed the patch here on Aurora
http://hg.mozilla.org/releases/l10n/mozilla-aurora/th/rev/1424c93a6d7d

Not sure what this was though (just before my commit), apparently it changed only permissions
http://hg.mozilla.org/releases/l10n/mozilla-aurora/th/rev/8a4c247f7e9f
(In reply to Francesco Lodolo [:flod] from comment #8)
> I committed the patch here on Aurora
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/th/rev/1424c93a6d7d
> 
> Not sure what this was though (just before my commit), apparently it changed
> only permissions
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/th/rev/8a4c247f7e9f

At least your landing will include all of the patch. Thanks for your help!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: