Newer revision nag notice sent even though it has been clicked and the page has been updated

VERIFIED FIXED in Builder 0.9

Status

addons.mozilla.org Graveyard
Add-on Builder
P1
blocker
VERIFIED FIXED
7 years ago
3 years ago

People

(Reporter: ashah, Assigned: seanmonstar)

Tracking

unspecified
Builder 0.9

Details

(Reporter)

Description

7 years ago
In an addon, create a folder. Upload any html file in that folder.
The spinner keeps spinning and then after sometime, I get a message saying a new version of the builder is available. I clicked on it and the page was refreshed.

Then I again tried to add an html file inside a folder and again, the spinner kept spinning, giving me the new version message again.

Updated

7 years ago
Severity: normal → blocker
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → Builder 0.9
(Assignee)

Comment 1

7 years ago
This is entirely an encoding error. There are special characters inside the HTML file.

For the new version message, when uploading, a revision is saved, and the attachment then gets saved to the revision. Since the encoding error happens, the attachment isnt save, but there is a new revision.
(Assignee)

Updated

7 years ago
Assignee: nobody → smcarthur
(Assignee)

Comment 2

7 years ago
landed in staging https://github.com/mozilla/FlightDeck/commit/1bc542494c2db29702bd743e437bac0436b8e957

This fixes the immediate issue regarding the encoding of the attachment. It passes back error message, so you at least know something wrong happened.

However, getting the revision to rollback (such that a new revision doesnt get created) seems to be more work than simply assigning "@transaction.commit_on_success". I suggest that it become its own ticket, and be targeted for 0.9.1.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

7 years ago
New bug filed based on the above comment - 

https://bugzilla.mozilla.org/show_bug.cgi?id=640212
(Reporter)

Updated

7 years ago
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.