639925 - Newer revision nag notice sent even though it has been clicked and the page has been updated

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P1)

Description

[Ayan Shah[:ashah]]

In an addon, create a folder. Upload any html file in that folder.
The spinner keeps spinning and then after sometime, I get a message saying a new version of the builder is available. I clicked on it and the page was refreshed.

Then I again tried to add an html file inside a folder and again, the spinner kept spinning, giving me the new version message again.

Comment 1

[Sean McArthur [:seanmonstar]]

This is entirely an encoding error. There are special characters inside the HTML file.

For the new version message, when uploading, a revision is saved, and the attachment then gets saved to the revision. Since the encoding error happens, the attachment isnt save, but there is a new revision.

Comment 2

[Sean McArthur [:seanmonstar]]

landed in staging https://github.com/mozilla/FlightDeck/commit/1bc542494c2db29702bd743e437bac0436b8e957

This fixes the immediate issue regarding the encoding of the attachment. It passes back error message, so you at least know something wrong happened.

However, getting the revision to rollback (such that a new revision doesnt get created) seems to be more work than simply assigning "@transaction.commit_on_success". I suggest that it become its own ticket, and be targeted for 0.9.1.

Comment 3

[Ayan Shah[:ashah]]

New bug filed based on the above comment - 

https://bugzilla.mozilla.org/show_bug.cgi?id=640212