Closed Bug 640014 Opened 9 years ago Closed 9 years ago

Remove duplicate key_lockscreen from browser.xul

Categories

(Firefox for Android Graveyard :: General, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

(Whiteboard: [has patch][fennec-checkin-postrc])

Attachments

(1 file)

Attached patch patchSplinter Review
This line should be Maemo-only, but it appears in both the Maemo and all-OS sections.
Attachment #517890 - Flags: review?(mark.finkle)
Attachment #517890 - Flags: review?(mark.finkle) → review+
probably fine for post-4
Whiteboard: [has patch][can land after fennec 4.0]
Whiteboard: [has patch][can land after fennec 4.0] → [has patch][fennec-checkin-post4.0]
It should be all-OS not maemo only, right? At least for debugging purpose I think (there is a popup if i remember correctly)
Yes, there's a popup, but otherwise no effect on non-Maemo platforms.  If we need to debug this on desktop, we can just remove the ifdef while debugging.
(In reply to comment #3)
> Yes, there's a popup, but otherwise no effect on non-Maemo platforms.  If we
> need to debug this on desktop, we can just remove the ifdef while debugging.

does it mean there is no way to lock the screen orientation on Android?
(In reply to comment #4)
> does it mean there is no way to lock the screen orientation on Android?

We don't have a way in Gecko to lock the screen orientation in Android, but we could implement one using setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_NOSENSOR):

http://developer.android.com/reference/android/app/Activity.html#setRequestedOrientation%28int%29

It would be good to have a different UI for this on Android, since most Android devices don't have keyboards.
http://hg.mozilla.org/mobile-browser/rev/f442d398175c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][fennec-checkin-post4.0] → [has patch][fennec-checkin-postrc]
You need to log in before you can comment on or make changes to this bug.