640014 - Remove duplicate key_lockscreen from browser.xul

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This line should be Maemo-only, but it appears in both the Maemo and all-OS sections.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

probably fine for post-4

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

It should be all-OS not maemo only, right? At least for debugging purpose I think (there is a popup if i remember correctly)

Comment 3

[Matt Brubeck (:mbrubeck)]

Yes, there's a popup, but otherwise no effect on non-Maemo platforms.  If we need to debug this on desktop, we can just remove the ifdef while debugging.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #3)
> Yes, there's a popup, but otherwise no effect on non-Maemo platforms.  If we
> need to debug this on desktop, we can just remove the ifdef while debugging.

does it mean there is no way to lock the screen orientation on Android?

Comment 5

[Matt Brubeck (:mbrubeck)]

(In reply to comment #4)
> does it mean there is no way to lock the screen orientation on Android?

We don't have a way in Gecko to lock the screen orientation in Android, but we could implement one using setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_NOSENSOR):

http://developer.android.com/reference/android/app/Activity.html#setRequestedOrientation%28int%29

It would be good to have a different UI for this on Android, since most Android devices don't have keyboards.

Comment 6

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/f442d398175c