Roll local changes to treeclosure.py into repo (update treeclosure hook for mozilla-2.1, mobile-2.0, mozilla-2.0 trees)

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
7 years ago
3 years ago

People

(Reporter: nthomas, Assigned: nthomas)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
In Bug 639972 the hook was modified locally get get repos set up for Fennec 4.0. We need to upstream the change to the repo
 http://hg.mozilla.org/hgcustom/hghooks/log/default/mozhghooks/treeclosure.py
(Assignee)

Comment 1

7 years ago
jlaz, could you grab the diff from hg.m.o and attach it here ?
[root@dm-svn02 mozhghooks]# pwd
/repo/hg/mozilla/hgcustom/hghooks/mozhghooks
[root@dm-svn02 mozhghooks]# diff /repo/hg/libraries/mozhghooks/treeclosure.py treeclosure.py 
24,37c24,32
<     'mozilla-central': 'http://tinderbox.mozilla.org/Firefox/status.html',
<     'mozilla-2.1'    : 'http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mobile2.0',
<     'mozilla-2.0'    : 'http://tinderbox.mozilla.org/Firefox4.0/',
<     'mozilla-1.9.1'  : 'http://tinderbox.mozilla.org/Firefox3.5/status.html',
<     'mozilla-1.9.2'  : 'http://tinderbox.mozilla.org/Firefox3.6/status.html',
<     'mobile-browser' : 'http://tinderbox.mozilla.org/Mobile/status.html',
<     'mobile-2.0'     : 'http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mobile2.0',
<     'mobile-1.1'     : 'http://tinderbox.mozilla.org/Mobile1.1/status.html',
<     'places'         : 'http://tinderbox.mozilla.org/Places/status.html',
<     'electrolysis'   : 'http://tinderbox.mozilla.org/Electrolysis/status.html',
<     'tracemonkey'    : 'http://tinderbox.mozilla.org/TraceMonkey/status.html',
<     'try'            : 'http://tinderbox.mozilla.org/MozillaTry/status.html',
<     'try-comm-central': 'http://tinderbox.mozilla.org/ThunderbirdTry/status.html',
<     'shadow-central' : 'http://tinderbox.mozilla.org/Shadow-Central/status.html',
---
>     'mozilla-central': 'http://tinderbox.mozilla.org/Firefox/',
>     'comm-central'   : 'http://tinderbox.mozilla.org/Thunderbird/',
>     'mozilla-1.9.1'  : 'http://tinderbox.mozilla.org/Firefox3.5/',
>     'mozilla-1.9.2'  : 'http://tinderbox.mozilla.org/Firefox3.6/',
>     'mobile-browser' : 'http://tinderbox.mozilla.org/Mobile/',
>     'places'         : 'http://tinderbox.mozilla.org/Places/',
>     'electrolysis'   : 'http://tinderbox.mozilla.org/Electrolysis/',
>     'tracemonkey'    : 'http://tinderbox.mozilla.org/TraceMonkey/',
>     'try'            : 'http://tinderbox.mozilla.org/MozillaTry/'
52c47
<         if re.compile('<span id="tree-?status".*CLOSED.*<span id="extended-status">').search(text) :
---
>         if re.compile('<span id="treestatus".*CLOSED.*<span id="extended-status">').search(text) :
[root@dm-svn02 mozhghooks]#
Group: infra, mozilla-corporation-confidential

Updated

7 years ago
Group: infra
(Assignee)

Comment 3

7 years ago
Created attachment 517913 [details] [diff] [review]
Roll up all local changes

Fixes:
* Firefox4.0 missing status.html
* adds new trees

When we deploy this again we'll fix the (accidental?) regression of the status.html fix of bug 629847.
Attachment #517913 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

7 years ago
Summary: Update treeclosure hook for mozilla-2.1 and mobile-2.0 trees → Roll local changes to treeclosure.py into repo (update treeclosure hook for mozilla-2.1, mobile-2.0, mozilla-2.0 trees)
Comment on attachment 517913 [details] [diff] [review]
Roll up all local changes

Is there any reason this is MoCo confidential? 

In the future, note that I would have no problem with landing changes like this in this repo and asking for post-facto review. I think that's saner than having local changes on the hg servers, that's just asking for trouble.
Attachment #517913 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → nrthomas
(Assignee)

Comment 5

6 years ago
Comment on attachment 517913 [details] [diff] [review]
Roll up all local changes

Belated landed this
 http://hg.mozilla.org/hgcustom/hghooks/rev/31a13eb17a38

It'll get deployed after bug 649468 is redone and landed.
(Assignee)

Comment 6

6 years ago
This will be fixed by bug 649468 soon enough.
Group: mozilla-corporation-confidential
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Depends on: 649468
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering

Comment 7

3 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/37d250a91ee0
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.