640046 - With "Hard Blockers Counter", closing one single-tab window triggers a "Confirm Close" dialog in another window

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STEPS TO REPRODUCE:
 0. Do some *magic* with your profile to make it susceptible to this bug.  (Not yet sure what magic is required -- all I know is I can't reproduce in a fresh profile.)

 1. Start Firefox, which brings up "Window A".  Open multiple tabs.
 2. File | New Window, to generate "Window B".
 3. Close "Window B" (a single-tab window) by clicking the 'close' button on its titlebar.

ACTUAL RESULTS: Window B closes (good), but then a dialog appears over Window A, saying:
>  Confirm close
>  =============
>  You are about to close 6 tabs. Are you sure you want to continue?
>  [x] Warn me when I attempt to close multiple tabs
>                                               [Cancel] [Close tabs]

EXPECTED RESULTS: No dialog should appear.


As noted in Step 0, I don't know what makes a profile susceptible to this, but I can't repro in a fresh profile.  khuey hits this as well, on his Windows nightly, so it's not platform-specific.

I hit this for the first time about 7-10 days ago, I think, so I believe it's a relatively recent regression.

Mozilla/5.0 (X11; Linux x86_64; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre

Comment 1

[Daniel Holbert [:dholbert]]

NOTE: If I close Window B with Ctrl+W (or equivalently, "File|Close Tab"), then I get EXPECTED RESULTS.  I only hit the bug when I click the "x" button on Window B's titlebar.

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to comment #0)
> STEPS TO REPRODUCE:
>  0. Do some *magic* with your profile to make it susceptible to this bug.

Woot, I isolated the necessary magic:
 0. Install "Hard Blockers Counter" addon*
https://addons.mozilla.org/en-US/firefox/addon/hard-blockers-counter/
 (no need to restart or anything)

After that, I can just open 2 "about:blank" tabs in my main browsing window, then open a new window, and then close the new window, and BAM I hit this bug.

(IIUC, this is unlikely to be a bug in Hard Blockers Counter itself - more likely a bug in our interaction with jetpacks in general)

Comment 3

[Daniel Holbert [:dholbert]]

I did some quick testing in older nightlies, and it looks like this isn't a regression after all -- it's broken at least as far back as late December.
Mozilla/5.0 (X11; Linux x86_64; rv:2.0b9pre) Gecko/20101224 Firefox/4.0b9pre

(So I think the "regression" I experienced recently was just from me installing the addon, not from Firefox itself breaking.)

zpao says there's a bug filed on this in the Addon SDK, and it's been fixed, but "Hard Blockers Counter" needs to be rebuilt in order for it to benefit from the fix.

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to comment #3)
> but "Hard Blockers Counter" needs to be rebuilt in order for it to benefit from
> the fix.

I've confirmed that if repeat the STR using a freshly-built* version of the extension, I get EXPECTED RESULTS.

* freshly-built by visiting https://builder.addons.mozilla.org/addon/1000065/latest/ ,  clicking 'Download', and then dragging and dropping the resulting file onto my Firefox window

Comment 5

[Daniel Holbert [:dholbert]]

(felipe tells me that the (fixed) bug in the Add-on SDK is bug 628188.)

Tentatively assigning to gandalf - gandalf, would you mind rebuilding your add-on to fix this?

(Now that blocker-count is 0-1, it's probably not a huge deal, but it'd be nice to save stress from other nightly testers who happen to hit this bug and spend time pursuing it as a regression in Firefox, as happened with me & khuey)

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Daniel: sure, I'll update it ASAP once the builder gets the new AddonSDK version :)

Comment 7

[Daniel Holbert [:dholbert]]

Great, thanks!

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

aaand wontfix ;)