Last Comment Bug 640062 - Panorama tabs-from-other-windows button displays  
: Panorama tabs-from-other-windows button displays  
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: Trunk
: All All
P4 normal
: Firefox 6
Assigned To: Raymond Lee [:raymondlee]
Depends on:
Blocks: 653099
  Show dependency treegraph
Reported: 2011-03-08 18:33 PST by Anthony Hughes (:ashughes) [GFX][QA][Mentor]
Modified: 2016-04-12 14:00 PDT (History)
8 users (show)
ehsan: in‑testsuite+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

Screenshot (294.99 KB, image/png)
2011-03-08 18:35 PST, Anthony Hughes (:ashughes) [GFX][QA][Mentor]
no flags Details
v1 (1.04 KB, patch)
2011-04-04 13:27 PDT, Raymond Lee [:raymondlee]
ian: review+
ttaubert: feedback+
Details | Diff | Splinter Review
v2 (2.31 KB, patch)
2011-04-11 00:05 PDT, Raymond Lee [:raymondlee]
ian: review+
Details | Diff | Splinter Review
Patch for checkin (2.29 KB, patch)
2011-04-11 17:45 PDT, Raymond Lee [:raymondlee]
no flags Details | Diff | Splinter Review

Description User image Anthony Hughes (:ashughes) [GFX][QA][Mentor] 2011-03-08 18:33:47 PST
When searching for a tab from another window, Panorama displays a message at the bottom with a button to switch to the tab. The button itself works but displays "&nbps;" as the label.

1. Open a few tabs in the main window to different pages
2. Open a new window
3. Open the Tab Groups view
4. Click the search button
5. Type the name of one of the loaded pages

Tabs from other windows [ ]

Tabs from other windows [something_more_identifiable]
Comment 1 User image Anthony Hughes (:ashughes) [GFX][QA][Mentor] 2011-03-08 18:35:28 PST
Created attachment 517951 [details]

1. Yahoo! Canada is loaded in the 2nd-last tab on the main window
2. Search from Panorama for "Yahoo" in the 2nd window
3. Button label at the bottom of the Panorama window
Comment 2 User image Srinivas 2011-03-09 04:17:40 PST
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:2.0) Gecko/20100101 Firefox/4.0

Works fine for me
Comment 3 User image B.J. Herbison 2011-03-09 07:12:47 PST
I am able to reproduce the problem as reported, for some web pages. For the search currently being made in another window, two tabs show up with correct titles and two as [ ]. The following worked correctly:

The following showed up as [ ]:

Windows XP
Mozilla/5.0 (Windows NT 5.2; WOW64; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre
Comment 4 User image B.J. Herbison 2011-03-09 07:25:07 PST
Some more experiments:

1. A tab open to bug 640062 from previous experiments, second window in existence.
2. Open a new tab with .
3. Search for "64" in the Tab Groups window.

Result: The "640062" tab showed up correctly, but "640044" showed up as [ ].

4. Closed the searching window, created a new window, opened tab groups, searched for 64:

Result: Both tab titles showed up correctly -- PROBLEM FIXED.

5. Opened second tab containing bug 640062 and searched 640052.

Result: one tab showed up correctly, the other didn't.

6. Trying to test the pattern I noticed, closed the second window, created a new window, open the tab group search and searched for 640062.

Result: This time the problem was NOT FIXED, one tab still showed up as [ ].

7. Closed the tab group window and created a new one:

Result: Still NOT fixed.
Comment 5 User image B.J. Herbison 2011-03-09 07:53:35 PST
Sorry for the multiple comments, but I can't stop testing this bug.

The tab group search will normally search on URLs and tab titles. It appears that in situations where [ ] shows in the search result, the tab group search does not search on the tab title.

Also (and this may be related or a separate bug), when a tab title change, tab group search doesn't notice.

These two behaviors are demonstrated in this sequence:

1. Open .
2. Create a second window and enter tab groups.
3. Click on a link in the Yahoo Canada tab. For me this went to:

Title: Seven years on, Bertuzzi hockey violence saga still heading to court

4. Open another tab with the article in step 3.
5. In tab groups, search for "4398825" (URL from article in step 3).

Result:  Two "tabs from other windows" displayed, one says "Yahoo! Canada", the other says "Seven year on, Bertuzzi hockey".
Expected: Both say "Seven year on, Bertuzzi hockey".

6. Search tab groups for "hockey".

Result: One search match.
Expected: Two search matches.
Comment 6 User image Anthony Hughes (:ashughes) [GFX][QA][Mentor] 2011-03-09 08:24:49 PST
This seems to work fine in Ubuntu 10.10, Windows XP, and Windows 7 with 4.0rc1. Looks like it could be a Mac-only bug.
Comment 7 User image Anthony Hughes (:ashughes) [GFX][QA][Mentor] 2011-03-09 08:26:51 PST
I'll try to find a regression window for this bug.
Comment 8 User image :Ehsan Akhgari 2011-03-09 12:57:08 PST
(In reply to comment #7)
> I'll try to find a regression window for this bug.

This is a bug which has been present since this feature was added.  I think it's caused by the fact that we're using innerHTML to grab the tab title, instead of textContent.

Comment 9 User image Anthony Hughes (:ashughes) [GFX][QA][Mentor] 2011-03-09 13:09:18 PST
I'm asking if this should block final, be taken as a ride-along, or should we wait until a 4.x to fix it?
Comment 10 User image Mike Beltzner [:beltzner, not reading bugmail] 2011-03-10 11:38:35 PST
I don't even think it's a .x fix, just a visible bug :(
Comment 11 User image Kevin Hanes 2011-03-18 13:33:45 PDT
I agree with Mike. I'll add it to our list, thanks for all the testing!
Comment 12 User image Kevin Hanes 2011-03-31 10:51:12 PDT
Comment 13 User image Raymond Lee [:raymondlee] 2011-04-04 13:27:10 PDT
Created attachment 524005 [details] [diff] [review]

trivial patch
Comment 14 User image Tim Taubert [:ttaubert] 2011-04-06 10:43:14 PDT
Comment on attachment 524005 [details] [diff] [review]

Looks good!
Comment 15 User image Ian Gilman [:iangilman] 2011-04-07 09:52:32 PDT
Comment on attachment 524005 [details] [diff] [review]

Comment 16 User image Raymond Lee [:raymondlee] 2011-04-11 00:05:39 PDT
Created attachment 525043 [details] [diff] [review]

Minor update to fix the test.

Passed Try.
Comment 17 User image Ian Gilman [:iangilman] 2011-04-11 09:30:00 PDT
Comment on attachment 525043 [details] [diff] [review]

Comment 18 User image Raymond Lee [:raymondlee] 2011-04-11 17:45:37 PDT
Created attachment 525245 [details] [diff] [review]
Patch for checkin
Comment 21 User image George Carstoiu 2011-04-22 04:10:47 PDT
Verified on Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110421 Firefox/6.0a1

Note You need to log in before you can comment on or make changes to this bug.