640065 - "Tabs from other windows" text disappears with background window

Status: RESOLVED FIXED

Description

[Anthony Hughes (:ashughes) [GFX][QA][Mentor]]

Created attachment 517952 [details]
Screenshot

When searching for tabs from other windows from within Panorama, there is text which says "Tabs from other windows".  This text disappears if this window loses focus.

Steps:
1. Open a few tabs in the main window to different pages
2. Open a new window
3. Open the Tab Groups view
4. Click the search button
5. Type the name of one of the loaded pages
6. Click the main window

Result:
"Tabs from other windows" text disappears.

Expected:
"Tabs from other windows" text should dim but still be visible.

Comment 1

[B.J. Herbison]

I don't see this issue on Windows XP. As I type another window still says "Tabs from other windows" in the bottom.

Mozilla/5.0 (Windows NT 5.2; WOW64; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre

Comment 2

[Anthony Hughes (:ashughes) [GFX][QA][Mentor]]

As reported by the Platform fields of this bug, I've only seen this on Mac.  I have not had  a chance to verify on Windows and Linux yet.  Also, this was checked with the 4.0rc1 build, not a nightly.

Comment 3

[Anthony Hughes (:ashughes) [GFX][QA][Mentor]]

Seems to work fine on Linux as well -- looks like a Mac-only bug.

Comment 4

[Anthony Hughes (:ashughes) [GFX][QA][Mentor]]

I'll try to find a regression window for this bug.

Comment 5

[Raymond Lee [:raymondlee]]

Created attachment 553678 [details] [diff] [review]
v1

Tested it on Linux, windows and Mac OSX and I only see the issue on Mac OSX.  This is the trivial patch to fix this.

Comment 6

[Tim Taubert [:ttaubert] (on PTO, back Aug 28th)]

Comment on attachment 553678 [details] [diff] [review]
v1

Review of attachment 553678 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! The change looks good to me. Is that a color code we already use somewhere? If not could you please post a screenshot and for ui-review?

Comment 7

[Raymond Lee [:raymondlee]]

Created attachment 553750 [details]
Mac Resizer Screenshot

Comment 8

[Raymond Lee [:raymondlee]]

Comment on attachment 553678 [details] [diff] [review]
v1

Please check the "Mac Resizer Screenshot" to see whether it's ok or not

Comment 9

[Tim Taubert [:ttaubert] (on PTO, back Aug 28th)]

(In reply to Raymond Lee [:raymondlee] from comment #8)
> Please check the "Mac Resizer Screenshot" to see whether it's ok or not

Are you sure that's the right screenshot for the right bug? ;)

Comment 10

[Raymond Lee [:raymondlee]]

Created attachment 553761 [details]
Search screenshot

Ooops, I was thinking other bug. Here is the right one!

Comment 11

[Raymond Lee [:raymondlee]]

Created attachment 553796 [details]
Search screenshot 2 (background window)

Comment 12

[Raymond Lee [:raymondlee]]

limi:  very trivial patch, could you review it please.  Thanks?

Comment 13

[Alex Limi (:limi) — Firefox UX Team]

Comment on attachment 553678 [details] [diff] [review]
v1

LGTM!

Comment 14

[Raymond Lee [:raymondlee]]

Created attachment 566174 [details] [diff] [review]
Patch for checkin

Pushed to try and waiting for the results
https://tbpl.mozilla.org/?tree=Try&rev=836cbbf5ac8a

Comment 15

[Raymond Lee [:raymondlee]]

(In reply to Raymond Lee [:raymondlee] from comment #14)
> Created attachment 566174 [details] [diff] [review] [diff] [details] [review]
> Patch for checkin
> 
> Pushed to try and waiting for the results
> https://tbpl.mozilla.org/?tree=Try&rev=836cbbf5ac8a

Passed Try!

Comment 16

[:Felipe Gomes (needinfo me!)]

https://hg.mozilla.org/integration/fx-team/rev/2f0ace471a17

Comment 17

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/2f0ace471a17