Closed Bug 640065 Opened 9 years ago Closed 8 years ago

"Tabs from other windows" text disappears with background window

Categories

(Firefox Graveyard :: Panorama, defect, P4)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 10

People

(Reporter: ashughes, Assigned: raymondlee)

Details

(Whiteboard: [4rc][fixed-in-fx-team])

Attachments

(4 files, 2 obsolete files)

Attached image Screenshot
When searching for tabs from other windows from within Panorama, there is text which says "Tabs from other windows".  This text disappears if this window loses focus.

Steps:
1. Open a few tabs in the main window to different pages
2. Open a new window
3. Open the Tab Groups view
4. Click the search button
5. Type the name of one of the loaded pages
6. Click the main window

Result:
"Tabs from other windows" text disappears.

Expected:
"Tabs from other windows" text should dim but still be visible.
I don't see this issue on Windows XP. As I type another window still says "Tabs from other windows" in the bottom.

Mozilla/5.0 (Windows NT 5.2; WOW64; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre
As reported by the Platform fields of this bug, I've only seen this on Mac.  I have not had  a chance to verify on Windows and Linux yet.  Also, this was checked with the 4.0rc1 build, not a nightly.
Seems to work fine on Linux as well -- looks like a Mac-only bug.
I'll try to find a regression window for this bug.
Priority: -- → P4
Target Milestone: --- → Future
Attached patch v1 (obsolete) — Splinter Review
Tested it on Linux, windows and Mac OSX and I only see the issue on Mac OSX.  This is the trivial patch to fix this.
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #553678 - Flags: review?(tim.taubert)
Comment on attachment 553678 [details] [diff] [review]
v1

Review of attachment 553678 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! The change looks good to me. Is that a color code we already use somewhere? If not could you please post a screenshot and for ui-review?
Attachment #553678 - Flags: review?(tim.taubert) → review+
Attached image Mac Resizer Screenshot (obsolete) —
Attachment #553678 - Flags: ui-review?
Comment on attachment 553678 [details] [diff] [review]
v1

Please check the "Mac Resizer Screenshot" to see whether it's ok or not
(In reply to Raymond Lee [:raymondlee] from comment #8)
> Please check the "Mac Resizer Screenshot" to see whether it's ok or not

Are you sure that's the right screenshot for the right bug? ;)
Attached image Search screenshot
Ooops, I was thinking other bug. Here is the right one!
Attachment #553750 - Attachment is obsolete: true
Attachment #553678 - Flags: ui-review? → ui-review?(limi)
limi:  very trivial patch, could you review it please.  Thanks?
Comment on attachment 553678 [details] [diff] [review]
v1

LGTM!
Attachment #553678 - Flags: ui-review?(limi) → ui-review+
Pushed to try and waiting for the results
https://tbpl.mozilla.org/?tree=Try&rev=836cbbf5ac8a
Attachment #553678 - Attachment is obsolete: true
(In reply to Raymond Lee [:raymondlee] from comment #14)
> Created attachment 566174 [details] [diff] [review] [diff] [details] [review]
> Patch for checkin
> 
> Pushed to try and waiting for the results
> https://tbpl.mozilla.org/?tree=Try&rev=836cbbf5ac8a

Passed Try!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2f0ace471a17
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [4rc] → [4rc][fixed-in-fx-team]
Target Milestone: Future → Firefox 10
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.