640090 - Give account central system colors for non-Windows themes

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Jim Porter (:squib)]

Attachment: Do this for Linux

Bug 620467 gave account central system colors on Windows. We should probably do this for Mac and Linux too.

Here's a patch for Linux. Not sure what the colors should be on Mac, since I can't really test them out...

Comment 1

[Jim Porter (:squib)]

bwinton/clarkbw/andreasn, do you have any ideas for the Mac version of this patch? I'm not sure what particular system colors I should be using.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

(In reply to comment #1)
> bwinton/clarkbw/andreasn, do you have any ideas for the Mac version of this
> patch? I'm not sure what particular system colors I should be using.

Tell you what, if you use the same colours you were using for Linux, I'll run it and take a screenshot for you…  :)

Thanks,
Blake.

Comment 3

[Jim Porter (:squib)]

Attachment: Add possible Mac theme

This is 100% guesswork on the Mac theme, but maybe it'll turn out ok! :)

Comment 4

[Jim Porter (:squib)]

If that version looks awful, then a screenshot of this page would be useful: http://www.teamboxel.com/misc/colors.html (it's a collection of swatches of all the Mozilla theme-dependent color values from https://developer.mozilla.org/en/CSS/color_value).

Comment 5

[Blake Winton (:bwinton) (:☕️)]

The screenshot of the colour page:
http://dl.dropbox.com/u/2301433/MacMozillaColours.png

More screenshots coming soon.  ;)

Thanks,
Blake.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Attachment: Old and new Mac styling.

It looks a little too white to me, given the colour of the folder pane beside it.

"WindowFrame" seems like it might be a better choice.

On the other hand, the content pane is white, and the message list alternates between white and blue…  Maybe it's not so bad.  Bryan, Andreas, what do you two think?

Thanks,
Blake.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 521125 [details] [diff] [review]
Add possible Mac theme

>+++ b/mail/themes/gnomestripe/mail/accountCentral.css
>@@ -59,55 +60,58 @@ separator.thin {
> .acctCentralLinkText:hover:active {
>-  color: #000000;
>+  color: -moz-FieldText;
> }
>+++ b/mail/themes/pinstripe/mail/accountCentral.css
>@@ -60,65 +60,63 @@ separator.thin {
> /* ::::: links ::::: */
> .acctCentralLinkText:hover:active {
>-  color: #000000;
>+  color: -moz-FieldText;
> }

I think we should use -moz-activehyperlinktext for these.
I also think that the selector should be changed to ".acctCentralLinkText:active", cause I noticed some weirdness when I clicked and held down one link, and then hovered over a different one…

I think you can also consider this an r=me, but feel free to re-request review if you change a bunch of stuff.

Thanks,
Blake.

Comment 8

[Andreas Nilsson (:andreasn)]

Comment on attachment 521169 [details]
Old and new Mac styling.

I think the white color looks pretty nice and fresh.
It also looks nice next to the calendars today pane and other white areas we use in Thunderbird.

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 521169 [details]
Old and new Mac styling.

white is the new gray!

Comment 10

[Jim Porter (:squib)]

Checked in with comment 7 addressed: http://hg.mozilla.org/comm-central/rev/586c2360de48