640120 - After clearing text using “X” button in the textbox, typing in findbar cannot be done anymore

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anna (Waverley)]

Attachment: The Actual Result

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110308 Firefox/4.0b13pre Fennec /4.0b6pre

Device: Motorola Droid 2 (Android 2.2)

1. Go to about:home
2. Go to the site menu -> Find In Page
3. Type the string "test"
4. Tap the “X” button. -> Tapping on “X” should empty input field.
5. Type in the string "mozilla"

Actual results: 
"mozilla" string is not visible in the findbar, only in the autosuggestion bar. Please see the attached photo.

Expected results:
After step 5, one should to be able to type in "mozilla".

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I'm not sure this is a Fennec bug or an Android behavior. I guess Fennec should be able to tell Android that no text is in the textbox and the Android suggestion list should clear.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

The bug summary says ".. typing in findbar cannot be done anymore" but I don't see any indication in comment 0 about that part. I only see the "mozilla" string is still in the Android suggestions.

Can you really not type in the textbox anymore?

Comment 3

[Anna (Waverley)]

I made a video: http://www.youtube.com/user/qaioana#p/u/0/Tc_812rowOM, maybe it helps...

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Mark, I can reproduce fairly easily.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 518364 [details] [diff] [review]
Patch

>+            try {
>+              let imeEditor = self.inputField.QueryInterface(Ci.nsIDOMNSEditableElement)
>+                                             .editor
>+                                             .QueryInterface(Ci.nsIEditorIMESupport);
>+              if (imeEditor.composing)
>+                imeEditor.forceCompositionEnd();
>+            } catch(e) { alert(e); }

No alert. I assume this for debugging. Either make the catch empty or send an error using Components.utils.reportError

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #5)
> No alert. I assume this for debugging.

Yes, that's a leftover!

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 518364 [details] [diff] [review]
Patch

This is a simple fix to an error that can break the find in page completely. Let's take it for final.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/056914c6c263
http://hg.mozilla.org/mobile-browser/rev/a26aa66f749e

Comment 9

[Anna (Waverley)]

VERIFIED FIXED on
 
Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110315 Firefox/4.0b13pre Fennec /4.0b6pre 

Device: Motorola Droid 2 (Android 2.2)