Closed Bug 640120 Opened 10 years ago Closed 10 years ago

After clearing text using “X” button in the textbox, typing in findbar cannot be done anymore

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: anamaria.moldovan, Assigned: vingtetun)

Details

Attachments

(2 files)

Attached image The Actual Result
Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110308 Firefox/4.0b13pre Fennec /4.0b6pre

Device: Motorola Droid 2 (Android 2.2)

1. Go to about:home
2. Go to the site menu -> Find In Page
3. Type the string "test"
4. Tap the “X” button. -> Tapping on “X” should empty input field.
5. Type in the string "mozilla"

Actual results: 
"mozilla" string is not visible in the findbar, only in the autosuggestion bar. Please see the attached photo.

Expected results:
After step 5, one should to be able to type in "mozilla".
I'm not sure this is a Fennec bug or an Android behavior. I guess Fennec should be able to tell Android that no text is in the textbox and the Android suggestion list should clear.
Summary: After clearing text using “X” menu button, typing in findbar cannot be done anymore → After clearing text using “X” button in the textbox, typing in findbar cannot be done anymore
The bug summary says ".. typing in findbar cannot be done anymore" but I don't see any indication in comment 0 about that part. I only see the "mozilla" string is still in the Android suggestions.

Can you really not type in the textbox anymore?
I made a video: http://www.youtube.com/user/qaioana#p/u/0/Tc_812rowOM, maybe it helps...
Attached patch PatchSplinter Review
Mark, I can reproduce fairly easily.
Assignee: nobody → 21
Attachment #518364 - Flags: review?(mark.finkle)
Comment on attachment 518364 [details] [diff] [review]
Patch

>+            try {
>+              let imeEditor = self.inputField.QueryInterface(Ci.nsIDOMNSEditableElement)
>+                                             .editor
>+                                             .QueryInterface(Ci.nsIEditorIMESupport);
>+              if (imeEditor.composing)
>+                imeEditor.forceCompositionEnd();
>+            } catch(e) { alert(e); }

No alert. I assume this for debugging. Either make the catch empty or send an error using Components.utils.reportError
Attachment #518364 - Flags: review?(mark.finkle) → review+
(In reply to comment #5)
> No alert. I assume this for debugging.

Yes, that's a leftover!
Comment on attachment 518364 [details] [diff] [review]
Patch

This is a simple fix to an error that can break the find in page completely. Let's take it for final.
Attachment #518364 - Flags: approval2.0+
VERIFIED FIXED on
 
Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110315 Firefox/4.0b13pre Fennec /4.0b6pre 

Device: Motorola Droid 2 (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.