If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Report type contains NotImplementedError as value

VERIFIED FIXED

Status

Testing Graveyard
Mozmill
VERIFIED FIXED
7 years ago
a year ago

People

(Reporter: whimboo, Assigned: Jeff Hammel)

Tracking

Details

(Whiteboard: [mozmill-2.0+])

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
With the latest changeset on master the report_type entry in the report written out by Mozmill contains the following value: "report_type": "NotImplementedError"

Looks like something broke in the last couple of weeks probably due to the refactoring.
(Reporter)

Updated

7 years ago
Whiteboard: [mozmill-2.0?]
(Reporter)

Updated

7 years ago
Blocks: 636746
(Assignee)

Updated

7 years ago
Assignee: nobody → jhammel
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Updated

7 years ago
Whiteboard: [mozmill-2.0?] → [mozmill-2.0+]
(Assignee)

Comment 1

7 years ago
Created attachment 519558 [details] [diff] [review]
remove report_type entirely, deprecated
Attachment #519558 - Flags: review?(fayearthur+bugs)
Comment on attachment 519558 [details] [diff] [review]
remove report_type entirely, deprecated

no more MozmillRestart, so this make sense.
Attachment #519558 - Flags: review?(fayearthur+bugs) → review+
(Assignee)

Comment 3

7 years ago
yeah;  when we gained the ability to run restart and non-restart tests in the same (python) process, report_type no longer made since, which is when I returned the string NotImplementedError (note: string, not the exception of the same name). I forgot the reason -- probably because a quick consensus could not be reached on what (if anything).  This is just cleanup from that which makes more sense as the line between restart and non-restart tests becomes increasingly blurred.
(Assignee)

Comment 4

7 years ago
pushed to master: https://github.com/mozautomation/mozmill/commit/b19629cb9725d454ddc5c48e5e0f22bc574d77d7
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

7 years ago
That change will need a fix in our dashboard code, so we don't fail on a non-existing report_type field. Otherwise I'm fine with the removal.
(Reporter)

Updated

7 years ago
Blocks: 642080
(Assignee)

Comment 6

7 years ago
If it helps to return a stub value, we can, but there's no longer a distinction between restart and non-restart runs as.
(Reporter)

Comment 7

7 years ago
If you could simply include "mozmill-test" as report type it would be great.
(Assignee)

Comment 8

7 years ago
Created attachment 519726 [details] [diff] [review]
include a (dummy) report type

adds in a dummy report type
Attachment #519726 - Flags: review?(ahalberstadt)
(Assignee)

Comment 9

7 years ago
(In reply to comment #7)
> If you could simply include "mozmill-test" as report type it would be great.

see comment #8
Comment on attachment 519726 [details] [diff] [review]
include a (dummy) report type

r+
Attachment #519726 - Flags: review?(ahalberstadt) → review+
(Assignee)

Comment 11

7 years ago
(In reply to comment #9)
> (In reply to comment #7)
> > If you could simply include "mozmill-test" as report type it would be great.
> 
> see comment #8

pushed to master: https://github.com/mozautomation/mozmill/commit/81e14ef3f80f1097ab763ec36ad1ee480232216e
(Reporter)

Comment 12

7 years ago
Looks good. Thanks Jeff!
Status: RESOLVED → VERIFIED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.