640155 - [webby] Add is_retired flag to webprojects

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect, P1)

Description

[Staś Małolepszy :stas]

or maybe is_archived?

Comment 1

[Axel Hecht [:Pike]]

I thought we had a related bug for Application and AppVersion in shipping, but I can't find it.

We should probably share the mindset for this among project-like things.

Comment 2

[Staś Małolepszy :stas]

Maybe you were thinking about life.Locale, bug 562278?

I'm all for standardizing things.  Anything else we should discuss here except for the actual name of the flag?

Comment 3

[Axel Hecht [:Pike]]

That might be over-engineering it, academically, we could create a mix-in model and a manager that defaults to not-showing the retired projects.

For the name, I find fields with '_' to be hard to query on, mixing __ and _ makes stuff hard to read and type.

Also the field type can be discussed, we could do something like making "archived" a DateTimeField.

Comment 4

[Staś Małolepszy :stas]

Attachment: Patch

For the sake of simplicity and consistency with webby.models I went for a boolean is_archived flag.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 530030 [details] [diff] [review]
Patch

looks good, r+

Comment 6

[Staś Małolepszy :stas]

Landed on master:

https://github.com/mozilla/elmo/commit/cdd3efd567483463a9cf8f36b62b79306b9e5bbb

And develop:

https://github.com/mozilla/elmo/commit/89c191540c39856d9275a9b7b7b2664b1a0b3152

I'll update production and run the SQL later today.

Comment 7

[Staś Małolepszy :stas]

I ran the SQL on prod and test and git pulled on both, too.