640191 - UndefinedError: list object has no element 1 on reviewlog page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons-next.allizom.org/z/en-US/editors/reviewlog


traceback details:

File "/data/amo_python/www/next/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/next/zamboni/apps/amo/decorators.py", line 22, in wrapper
   return func(request, *args, **kw)

 File "/data/amo_python/www/next/zamboni/apps/editors/views.py", line 35, in wrapper
   return func(request, *args, **kw)

 File "/data/amo_python/www/next/zamboni/apps/editors/views.py", line 290, in reviewlog
   return jingo.render(request, 'editors/reviewlog.html', data)

 File "/data/amo_python/www/next/zamboni/vendor/src/jingo/jingo/__init__.py", line 78, in render
   rendered = render_to_string(request, template, context)

 File "/data/amo_python/www/next/zamboni/vendor/src/jingo/jingo/__init__.py", line 96, in render_to_string
   return template.render(**get_context())

 File "/usr/lib/python2.6/site-packages/jinja2/environment.py", line 891, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/amo_python/www/next/zamboni/apps/editors/templates/editors/reviewlog.html", line 1, in top-level template code
   {% extends "editors/base.html" %}

 File "/data/amo_python/www/next/zamboni/apps/editors/templates/editors/base.html", line 1, in top-level template code
   {% extends "base.html" %}

 File "/data/amo_python/www/next/zamboni/templates/base.html", line 99, in top-level template code
   {% block main_content %}

 File "/data/amo_python/www/next/zamboni/templates/base.html", line 104, in block "main_content"
   {% block content %}{% endblock %}

 File "/data/amo_python/www/next/zamboni/apps/editors/templates/editors/reviewlog.html", line 41, in block "content"
   <a href="{{ url('editors.review', item.arguments[1].id) }}">

 File "/usr/lib/python2.6/site-packages/jinja2/environment.py", line 371, in getattr
   return getattr(obj, attribute)

UndefinedError: list object has no element 1

Comment 1

[Wil Clouser [:clouserw]]

dd did these pages

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Not sure what happened, but I made it more failsafe.

http://github.com/jbalogh/zamboni/commit/640a5b6

Comment 3

[krupa raj[:krupa]]

loading https://addons.allizom.org/z/en-US/editors/reviewlog doesn't result in a tarceback. Marking this verified.