Closed
Bug 640212
Opened 13 years ago
Closed 13 years ago
If an action fails after making a revision, the revision should be removed
Categories
(addons.mozilla.org Graveyard :: Add-on Builder, defect, P2)
addons.mozilla.org Graveyard
Add-on Builder
Tracking
(Not tracked)
VERIFIED
FIXED
Builder 0.9.4
People
(Reporter: smcarthur, Assigned: smcarthur)
References
Details
Attachments
(1 file)
|
213.52 KB,
image/jpeg
|
Details |
screenshot shows that revision is retained when upload error occurs
Since most actions create a new revision, and then save things to that revision, when there is an error, we should rollback to before that revision was saved. Example can be found at https://bugzilla.mozilla.org/show_bug.cgi?id=639925
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → smcarthur
Priority: -- → P2
Target Milestone: --- → Builder 0.9.1
|
|
Assignee | |
Comment 1•13 years ago
|
||
It would seem that the easy way of doing this, using transactions, requires our tables to use InnoDB, not MyISAM.
Depends on: 633100
|
|
Assignee | |
Updated•13 years ago
|
Target Milestone: Builder 0.9.1 → Builder 0.9.2
|
|
Assignee | |
Updated•13 years ago
|
Target Milestone: Builder 0.9.2 → Builder 0.9.3
|
|
Assignee | |
Updated•13 years ago
|
Target Milestone: Builder 0.9.3 → Builder 0.9.4
|
|
Assignee | |
Comment 2•13 years ago
|
||
The use of transactions was already in place, so with 633100 completed, this should just work.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified in https://builder-addons-next.allizom.org/ revision is retained when an error occurs in uploading an attachment
|
||
Updated•10 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•