Closed
Bug 640234
Opened 14 years ago
Closed 14 years ago
[Join Us] Errors don't auto-scroll to the form
Categories
(Websites :: donate.mozilla.org, defect)
Websites
donate.mozilla.org
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stephend, Unassigned)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
695.83 KB,
image/png
|
Details |
Any validation errors on submitting the form in https://donate.mozilla.org/page/contribute/protect-the-web#act-3 don't auto-scroll back down to the form.
See screenshot.
Reporter | ||
Updated•14 years ago
|
Component: www.mozilla.org → donate.mozilla.org
QA Contact: www-mozilla-org → donate-mozilla-org
Comment 1•14 years ago
|
||
We see this one more as a feature than bug, but we are looking at implementing.
That said, we thing that you would be able to get it going by adding something like this onto contrib pages that need this feature:
var form = jQuery('#contribution');
form.attr("action", form.attr("action") + "#act-3");
Comment 2•14 years ago
|
||
Good idea, Seth. We'll try this out and send over the code changes via Github (in addition to updating BSD) when completed.
Comment 3•14 years ago
|
||
Hey Devin, Seth, has this been sent over yet?
Comment 4•14 years ago
|
||
Not yet. We're working on this along with the FAQ styles this afternoon (along with any final blockers that may arise).
Comment 6•14 years ago
|
||
jQuery snippet added along with a handful of other fixes.
Tested and confirmed at (step 1: click "process" without entering data):
https://donate.mozilla.org/page/contribute/protect-the-web
Other detailed changes:
- Noticed mixed - and _ usage in locales, breaking translatable images. Added a fix that normalizes the locale variable used by images.
- The Javascript source (not compiled version) needed to be added to the project for the updates.
- Documented the JS compile process.
- Fixed issue with BASE_URL's protocol-relative syntax being replaced by http://. This breaks webfonts because BSD proxies all urls prefixed with http:// (what a terrible idea), and FF only accepts fonts from same domain. Added an explanatory comment above the constant.
- Updated the way require.js loads main.js to bring it up-to-date with latest version.
- Updated BSD assets
Reporter | ||
Comment 7•14 years ago
|
||
Devin: I've given you permissions in Bugzilla to mark bugs as resolved fixed (or verified, reopened, etc.).
Comment 8•14 years ago
|
||
Thanks, Stephen. :)
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 9•14 years ago
|
||
NP; thanks for fixing this -- really looks and behaves a lot better.
Verified FIXED on https://donate.mozilla.org/page/cde/Contribution/Charge#act-3.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•