64027 - tooltips don't work when embedding mozilla via gtkmozembed

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Maher Awamy]

Visiting the URL above and placing the mouse over the yahoo link yields a yahoo
tool tip in mozilla. Using any browser that embeds mozilla via gtkmozembed will
not show the tip.

Comment 1

[Maher Awamy]

I would like to add that the pref general.title.tip is enabled ..

Comment 2

[Christopher Blizzard (:blizzard)]

It's a XUL thing.

Comment 3

[Maher Awamy]

Anyway of doing this using GtkToolTip?

Comment 4

[Christopher Blizzard (:blizzard)]

I don't think that GtkToolTip is going to be used here.

I'm not sure what the deal is with tooltips and embedding.  I think pink might
know more but I could be wrong.  Pink, what's the deal?  Do you need XUL to do
tooltips in the current arrangement?

Comment 5

[Maher Awamy]

Any news on this yet Pink :)

Comment 6

[Mike Pinkerton (not reading bugmail)]

this depends on 62886, which i will land today. then someone just has to
implement the new nsITooltipListener api in on the webBrowserChrome object.

Comment 7

[Maher Awamy]

Attachment: Patch for implementing nsITooltipListener in GtkMozEmbedChrome

Comment 8

[Maher Awamy]

Well, the above patch implements this for GtkMozEmbedChrome, I could have sworn
I saw a gtk_tooltip_popup function before but Appearntly I was wrong, This is
the closest implementation I could come up with, see if you like that Chris.
Works perfectly here with Skip and TestGtkEmbed and Galeon all.

Comment 9

[Maher Awamy]

Attachment: Same patch but adds a gtk_label_set_line_wrap(label,TRUE) so that long titles can be wrapped correctly.

Comment 10

[Christopher Blizzard (:blizzard)]

To me.

Comment 11

[Christopher Blizzard (:blizzard)]

-> mozilla 0.8

Comment 12

[Christopher Blizzard (:blizzard)]

Update summary

Comment 13

[Christopher Blizzard (:blizzard)]

Attachment: patch that uses offsets correctly

Comment 14

[Christopher Blizzard (:blizzard)]

Attachment: patch that uses transient_for

Comment 15

[Stuart Parmenter]

r=pavlov

Comment 16

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Blizzard has agreed to fix tab-damage and spelling, and add some more comments
to appease me.  In return, I proffer my sr=.

Comment 17

[Christopher Blizzard (:blizzard)]

Checked in.