640364 - Validation of language packs fails with 'TypeError: 'NoneType' object is not iterable'

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: test file

steps to reproduce:
1. Validate the attached language pack

Validates fine in prod.

traceback details:

"Traceback (most recent call last):
  File "/data/amo_python/www/preview/zamboni/apps/devhub/tasks.py", line 27, in validator           
    result = _validator(upload.path) 
  File "/data/amo_python/www/preview/zamboni/apps/devhub/tasks.py", line 70, in _validator 
    spidermonkey=settings.SPIDERMONKEY) 
  File "/data/amo_python/www/preview/zamboni/vendor/src/amo-validator/validator/validate.py", line 37, in validate 
    validator.submain.prepare_package(bundle, path, expectation) 
  File "/data/amo_python/www/preview/zamboni/vendor/src/amo-validator/validator/submain.py", line 52, in prepare_package
    output = test_package(err, package, path, expectation) 
  File "/data/amo_python/www/preview/zamboni/vendor/src/amo-validator/validator/submain.py", line 137, in test_package 
    return test_inner_package(err, package_contents, package) 
  File "/data/amo_python/www/preview/zamboni/vendor/src/amo-validator/validator/submain.py", line 223, in test_inner_package 
    test_func(err, package_contents, xpi_package) 
  File "/data/amo_python/www/preview/zamboni/vendor/src/amo-validator/validator/testcases/l10ncompleteness.py", line 193, in test_lp_xpi 
    for ref_locale_name in ref_locales: 
TypeError: 'NoneType' object is not iterable

Comment 1

[Matt Basta [:basta]]

This issue is corrected by the fixes made for bug 638624

Comment 2

[Wil Clouser [:clouserw]]

(In reply to comment #1)
> This issue is corrected by the fixes made for bug 638624

mm, I didn't know this was dependent on a bug in a future milestone.  Bumping. :-/

Comment 3

[Wil Clouser [:clouserw]]

Krupa points out that this s a regression.  Matt, is this something that can be split out and fixed today?

Comment 4

[Matt Basta [:basta]]

Here's the patch for 638624, which will also fix this bug:

https://github.com/mozilla/amo-validator/pull/4

Comment 5

[Matt Basta [:basta]]

Fixed:

https://github.com/mozilla/amo-validator/commit/07f2f7eaf8f98745570f601956ab8a0394ca1bdd

Comment 6

[Wil Clouser [:clouserw]]

validator is updated in https://github.com/jbalogh/zamboni-lib/commit/77cab0b2bf193ad7d587313a2a90be6a3acb0474

Comment 7

[krupa raj[:krupa]]

Filed bug Bug 640748. No tracebacks on validating language packs. Marking this as verified.