Closed Bug 640504 Opened 13 years ago Closed 13 years ago

Qt-Fennec, Language Code is not read correctly from System.

Categories

(Firefox for Android Graveyard :: General, defect)

All
MeeGo
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jbos, Unassigned)

Details

Attachments

(1 file)

We are using the wrong function to read the system language:

http://mxr.mozilla.org/mozilla-central/source/intl/locale/src/nsLocaleService.cpp#185

it should be:
const char* lang = QLocale::system().name().toAscii();
OS: Linux → MeeGo
Hardware: x86 → ARM
Hardware: ARM → All
Attached patch Fix it.Splinter Review
Patch to fix the line.
Attachment #518318 - Flags: review?(romaxa)
Comment on attachment 518318 [details] [diff] [review]
Fix it.

yep, en_US is much better than "English"
Attachment #518318 - Flags: review?(romaxa) → review+
http://hg.mozilla.org/mozilla-central/rev/ee18eff42c2e
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: