Open
Bug 640579
Opened 13 years ago
Updated 10 years ago
Make Advanced search page compliant with WAI
Categories
(Bugzilla :: User Interface, enhancement)
Bugzilla
User Interface
Tracking
()
ASSIGNED
People
(Reporter: fdonalisio, Assigned: fdonalisio)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file, 3 obsolete files)
5.33 KB,
patch
|
LpSolit
:
review-
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101206 Ubuntu/10.10 (CK-IBM) (CK-IBM) Firefox/3.6.13 Build Identifier: We should change the Simple Search page to make it complaint with W3C Web Accessibility Initiative. Reproducible: Always
Assignee | ||
Updated•13 years ago
|
Updated•13 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 1•13 years ago
|
||
Remove WCAG 2.0 violations in the advanced search page Implements the following W3C accessibility techniques: -Using the title attribute to identify form controls when the label element cannot be used http://www.w3.org/TR/WCAG20-TECHS/H65.html -Providing a description for groups of form controls using fieldset and legend elements http://www.w3.org/TR/WCAG20-TECHS/H71.html
Attachment #519427 -
Flags: review?(timello)
Comment 2•13 years ago
|
||
Comment on attachment 519427 [details] [diff] [review] Remove WCAG 2.0 violations in the advanced search page >=== modified file 'template/en/default/search/boolean-charts.html.tmpl' >-</div> >\ No newline at end of file >+</div> Has the newline been removed or added? >=== modified file 'template/en/default/search/form.html.tmpl' >+ <select name="bug_id_type" id="bug_id_type" title="Olny included or excluded in the results"> Typo: Only >+ <select name="emailtype[% n %]" title="Match option" > Extra whitespace before >. >=== modified file 'template/en/default/search/search-advanced.html.tmpl' >+<fieldset class="bz_advanced_search_fieldset"> Does a fieldset really make sense here? The comment applies to the whole page, not to a specific group only.
Comment 3•13 years ago
|
||
Comment on attachment 519427 [details] [diff] [review] Remove WCAG 2.0 violations in the advanced search page See Comment #2
Attachment #519427 -
Flags: review?(timello) → review-
Assignee | ||
Comment 4•13 years ago
|
||
Implements the following W3C accessibility techniques: -Using the title attribute to identify form controls when the label element cannot be used http://www.w3.org/TR/WCAG20-TECHS/H65.html -Providing a description for groups of form controls using fieldset and legend elements http://www.w3.org/TR/WCAG20-TECHS/H71.html
Assignee: ui → francsd
Attachment #519427 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #526710 -
Flags: review?(timello)
Comment 5•13 years ago
|
||
Comment on attachment 526710 [details] [diff] [review] Remove WCAG 2.0 violations in the advanced search page Review of attachment 526710 [details] [diff] [review]: ----------------------------------------------------------------- Your patch is bit-rotted. I can't apply in the current trunk. You need to update it. ::: skins/standard/search_form.css @@ +201,4 @@ > margin-top: 1em; > } > > +.bz_advanced_search_fieldset { Use something like: fieldset.bz_search_by_people { } @@ +206,5 @@ > + margin-left: 0em; > + border: none; > +} > + > +.bz_advanced_search_legend { Instead of this, use: fieldset.bz_search_by_people legend { } Then you don't need to define the class="" in the <legend> tag. ::: template/en/default/search/form.html.tmpl @@ +391,4 @@ > </li> > <li> > <label for="chfieldfrom">between:</label> > + <input name="chfieldfrom" id="chfieldfrom" size="10" title="First day to be searched" Initial date @@ +397,5 @@ > id="button_calendar_chfieldfrom" > onclick="showCalendar('chfieldfrom')"><span>Calendar</span></button> > and > <div id="con_calendar_chfieldfrom"></div> > + <input name="chfieldto" size="10" id="chfieldto" title="Last day to be searched" Final/End date?
Attachment #526710 -
Flags: review?(timello) → review-
Assignee | ||
Comment 6•13 years ago
|
||
Implements the following W3C accessibility techniques: -Using the title attribute to identify form controls when the label element cannot be used http://www.w3.org/TR/WCAG20-TECHS/H65.html -Providing a description for groups of form controls using fieldset and legend elements http://www.w3.org/TR/WCAG20-TECHS/H71.html
Attachment #526710 -
Attachment is obsolete: true
Attachment #537817 -
Flags: review?
Assignee | ||
Updated•13 years ago
|
Attachment #537817 -
Flags: review? → review?(timello)
Comment 7•13 years ago
|
||
Comment on attachment 537817 [details] [diff] [review] Remove WCAG 2.0 violations in the advanced search page Review of attachment 537817 [details] [diff] [review]: ----------------------------------------------------------------- Please, update your patch. It's bit rotted.
Attachment #537817 -
Flags: review?(timello) → review+
Updated•12 years ago
|
Assignee: francsd → leosilva
Assignee | ||
Comment 8•12 years ago
|
||
Implements the following W3C accessibility techniques: -Using the title attribute to identify form controls when the label element cannot be used http://www.w3.org/TR/WCAG20-TECHS/H65.html -Providing a description for groups of form controls using fieldset and legend elements http://www.w3.org/TR/WCAG20-TECHS/H71.html
Assignee: leosilva → francsd
Attachment #537817 -
Attachment is obsolete: true
Attachment #643948 -
Flags: review?(glob)
Comment on attachment 643948 [details] [diff] [review] Remove WCAG 2.0 violations in the advanced search help page timello's probably a better pick to do this review; retargeting.
Attachment #643948 -
Flags: review?(glob) → review?(timello)
Comment 10•11 years ago
|
||
Comment on attachment 643948 [details] [diff] [review] Remove WCAG 2.0 violations in the advanced search help page >=== modified file 'template/en/default/search/field.html.tmpl' >+ <label for="[% field.name FILTER html %]to">to</label> <input name="[% field.name FILTER html %]to" This line is a bit too long. Move <input> on its own line. >=== modified file 'template/en/default/search/form.html.tmpl' >+<fieldset class="bz_search_by_people"> >+<legend>Search By People</legend> Why setting a fieldset for this section only, but not for the other ones? What's the rationale behind this?
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Frédéric Buclin from comment #10) > Comment on attachment 643948 [details] [diff] [review] > Remove WCAG 2.0 violations in the advanced search help page > > >=== modified file 'template/en/default/search/form.html.tmpl' > > >+<fieldset class="bz_search_by_people"> > >+<legend>Search By People</legend> > > Why setting a fieldset for this section only, but not for the other ones? > What's the rationale behind this? Grouping controls is most important for related radio buttons and checkboxes. http://www.w3.org/TR/WCAG20-TECHS/H71.html I suppose we could use in other fields, but since we also should avoid nesting fieldsets, I only put in the field I really thought it was necessary.
Updated•11 years ago
|
Attachment #643948 -
Flags: review?(timello) → review?
Comment 12•11 years ago
|
||
Comment on attachment 643948 [details] [diff] [review] Remove WCAG 2.0 violations in the advanced search help page Fixing empty review requests
Attachment #643948 -
Flags: review? → review?(LpSolit)
Updated•11 years ago
|
Attachment #643948 -
Flags: review?(LpSolit) → review?(glob)
Comment 13•10 years ago
|
||
Comment on attachment 643948 [details] [diff] [review] Remove WCAG 2.0 violations in the advanced search help page There has been a lot of changes in Bugzilla 5.0: several CSS files have been merged, and we moved from HTML4 to HTML5. Your patch no longer applies cleanly, unfortunately.
Attachment #643948 -
Flags: review?(glob) → review-
You need to log in
before you can comment on or make changes to this bug.
Description
•