Closed Bug 640589 Opened 9 years ago Closed 9 years ago

rename unbranded builds on /releases/mozilla-2.0 from Minefield to Tumucumaque

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Version:
4.0 Branch
Platform:
x86
All
Type:
defect
Priority:
Not set

Tracking

(status2.0 .1-fixed)

Status:
VERIFIED FIXED
Milestone:
mozilla4.0
Tracking Flags:
Tracking Status
status2.0 --- .1-fixed

People

(Reporter: beltzner, Assigned: philor)

References

Details

Attachments

(1 file)

Fix
2.59 KB, patch
Gavin
: review+
christian
: approval2.0+
Details | Diff | Splinter Review 
Since the plan is for any future Firefox 4 for Windows, Mac and Linux to be built off the /releases/mozilla-2.0 branch, we should change unbranded builds from that branch to use the park codename for the Firefox 4 project: Tumucumaque
(Yes, I know that we won't have nightly builds on that branch - that's cool)
Setting the default branding is actually a build system change.

cf 1.9.2:
 http://mxr.mozilla.org/mozilla1.9.2/source/browser/confvars.sh#53
 http://mxr.mozilla.org/mozilla1.9.2/source/browser/branding/unofficial/
Blocks: 566679
Component: Release Engineering → Build Config
OS: Mac OS X → All
Product: mozilla.org → Core
QA Contact: release → build-config
Version: other → unspecified
Attached patch Fix — — Splinter Review 
Been so many years you've probably forgotten, but apparently you review these.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #523509 - Flags: review?(gavin.sharp)
Product: Core → Firefox
QA Contact: build-config → build.config
Version: unspecified → 4.0 Branch
I actually wrote a patch for this but then left it on a remote computer I don't have access to, so I've been waiting until I have access to compare my patch to yours. That should happen today!
Comment on attachment 523509 [details] [diff] [review]
Fix

Actually I just did all the work of verifying this is OK in bug 648368.
Attachment #523509 - Flags: review?(gavin.sharp) → review+
Attachment #523509 - Flags: approval2.0?
Comment on attachment 523509 [details] [diff] [review]
Fix

Approved for releases/mozilla-2.0. Thanks!
Attachment #523509 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/releases/mozilla-2.0/rev/ef9fefb7311c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status2.0: --- → .1-fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0
Flags: in-testsuite-
Looks good. Marking as verified.
Status: RESOLVED → VERIFIED
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 4.0 → mozilla4.0
You need to log in before you can comment on or make changes to this bug.