Accessing "Download more dictionaries" from the Preferences dialog should open a content tab not the external browser

RESOLVED FIXED in Thunderbird 5.0b1

Status

Thunderbird
Preferences
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: standard8, Assigned: squib)

Tracking

unspecified
Thunderbird 5.0b1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
+++ This bug was initially created as a clone of Bug #640627 +++

AMO can now detect Thunderbird and offer to download dictionaries at the right time.

Therefore if the user selects to download dictionaries from the compose section in the preferences dialog we should open AMO in a tab so that users can install dictionaries directly.
Depends on: 620781
(Assignee)

Comment 1

7 years ago
Should this open a new 3pane like the Manage Addons button? Maybe it should depend on the OS, since the preferences dialog is non-modal on Linux (not sure about Mac).
(Assignee)

Comment 2

7 years ago
Created attachment 518549 [details] [diff] [review]
Open content tab for "Download more dictionaries"

Here we go. No tests since trying to test this seems to cause timeouts, but it's a really simple fix so I'm reasonably confident that it's safe.
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
Attachment #518549 - Flags: review?(bugzilla)
(Reporter)

Comment 3

7 years ago
Comment on attachment 518549 [details] [diff] [review]
Open content tab for "Download more dictionaries"

So as we're including utilityOverlay.js I think you may as well change the call to openDictionaryList() that you're adding in bug 620781.

Then we can get rid of the setAttribute for getDictionariesURL in the init function in gComposePane in compose.js and the duplicate getDictionaryURL() function in the same (we should really be doing those on init of the preferences pane anyway, seeing as the user might not actually hit the button).
Attachment #518549 - Flags: review?(bugzilla) → review-
(Assignee)

Comment 4

7 years ago
Created attachment 519596 [details] [diff] [review]
Use new function from bug 620781

I had to change the openDictionaryList function from bug 620781 to take an argument to open in a new window, but otherwise this patch is pretty straightforward.
Attachment #518549 - Attachment is obsolete: true
Attachment #519596 - Flags: review?(bugzilla)
(Reporter)

Updated

7 years ago
Attachment #519596 - Flags: review?(bugzilla) → review+
(Assignee)

Comment 5

7 years ago
Adding checkin-needed.

One day I hope that I'll be able to have the dictionary open in a new tab instead of a new window, but that's dependent on the prefs dialog becoming a tab too...
Keywords: checkin-needed
(Reporter)

Comment 6

7 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/22394e7d3728
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a4
(Reporter)

Updated

7 years ago
status-thunderbird5.0: wanted → ---
You need to log in before you can comment on or make changes to this bug.