640630 - about:home advertises add-ons that are installed already

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Thomas Arend [:tarend]]

Attachment: Home Screen advertises already installed add-ons

(1) Install add-ons like "Personas" or "Home Links"
(2) Restart Browser

Result: about:home still shows the same add-ons in section "Add-ons for your Firefox"
Expected: installed add-ons won't be advertised again. Instead, other add-ons are shown.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Probably due to the fact we load those add-ons from a cache, which might not be updated soon enough.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

.. we use the cache because connecting live to AMO kills startup performance.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

At least we can prevent showing the addon if it is already installed, and if all the suggestions are installed we can hide the panel (and perform a cache update in the background)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #3)
> At least we can prevent showing the addon if it is already installed, and if
> all the suggestions are installed we can hide the panel (and perform a cache
> update in the background)

We could do both of these things. Let's just make sure we don't regress performance.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch filters the list of already installed addons

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 532598 [details] [diff] [review]
Patch

We'll need to watch for any slow down in the start page due to the AddonManager. I also wonder if we are updating the json cache file often enough. Right now it is updated during the addon update ping in components/AddonUpdateService.js 
http://mxr.mozilla.org/mozilla-central/source/mobile/components/AddonUpdateService.js#112

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mozilla-central/rev/ae15b103571c

Comment 8

[Anna (Waverley)]

VERIFIED FIXED on:

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110524 Firefox/6.0a1 Fennec/6.0a1 

Device: HTC Desire Z (Android 2.2)