TestRequestReview.test_purgatory_to_public is flaky because it depends on timing

RESOLVED FIXED in 4.x (triaged)

Status

addons.mozilla.org Graveyard
Code Quality
RESOLVED FIXED
7 years ago
2 years ago

People

(Reporter: jbalogh, Unassigned)

Tracking

4.x (triaged)

Details

(URL)

(Reporter)

Description

7 years ago
devhub.tests.test_views.TestRequestReview.test_purgatory_to_public

Stacktrace

Traceback (most recent call last):
  File "/home/hudson-slave/workspace/amo-master/vendor/src/django/django/utils/unittest/case.py", line 339, in run
    testMethod()
  File "/home/hudson-slave/workspace/amo-master/apps/devhub/tests/test_views.py", line 3814, in test_purgatory_to_public
    assert_close_to_now(self.addon.nomination_date)
  File "/home/hudson-slave/workspace/amo-master/apps/devhub/tests/test_views.py", line 66, in assert_close_to_now
    eq_(dt.timetuple()[:5], datetime.now().timetuple()[:5])
  File "/home/hudson-slave/workspace/amo-master/vendor/lib/python/nose/tools.py", line 31, in eq_
    assert a == b, msg or "%r != %r" % (a, b)
AssertionError: (2011, 3, 10, 12, 6) != (2011, 3, 10, 12, 7)
(Reporter)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.