640748 - Language packs with nested jars fail validation

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: test file

steps to reproduce:
1.Upload the attached lang pack


observed behavior:

Language packs with nested jars fail validation-

https://addons-next.allizom.org/en-US/developers/upload/8b8d3a574aef4de4a569e500cbf1dc6f

Comment 1

[Wil Clouser [:clouserw]]

Kinda sounds like a dupe of the "see also" bug, but apparently this one is for lang packs.  -> basta; please fix for all add-on types.

Comment 2

[Matt Basta [:basta]]

The language pack does fail validation on my local copy, but it doesn't error out with a traceback. All of the errors generated by the validator look legitimate (unchanges/missing entities). Unless I can get a traceback, I can't really debug this any further.

Comment 3

[krupa raj[:krupa]]

Is this a valid error?

Addon missing install.rdf.

Error: All addons require an install.rdf file.
chrome/en-za.jar

Comment 4

[Matt Basta [:basta]]

I'm not seeing that error locally. Where are you seeing that? A recent merge into mozilla/origin fixed an issue that produced errors like that.

Comment 5

[Wil Clouser [:clouserw]]

It's on PAMO.  I updated zamboni-lib, but maybe it's having troubles pulling from github or something

Comment 6

[Matt Basta [:basta]]

Maybe I'm seeing the wrong output; for me, the link to addons-next in comment 1 shows an internal server error for all four tests. The request for the JSON is 403'd.

Comment 7

[Matt Basta [:basta]]

After this commit is live, can someone verify that this bug still exists?

https://github.com/mozilla/amo-validator/commit/85bba7c1889dcc25a3edd8b2377561c96e307d1b

Comment 8

[Wil Clouser [:clouserw]]

It's on PAMO now.  Let's see.

Comment 9

[krupa raj[:krupa]]

verified fixed @ https://addons-next.allizom.org/en-US/developers/upload/8a38ee94f93346fc90f21d1d063605e2

Thanks!