640759 - Move general testrun script to 'testrun_functional.py'

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Automation, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We have to rename the testrun script for the formerly general testrun to match the naming scheme of the new functional testrun.

Some steps have to be done here:
1. Update the TestRun classes
2. Create new test environments for Mozmill Crowd which will define available test-runs.
3. Release Mozmill Crowd with environment update support (next quarter)
4. Land all those changes

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

Mozmill Crowd 0.1.4 has been fully adopted meanwhile, which makes us safe from removing the deprecated test-run script.

Comment 2

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Seems like this patch just nukes testrun_general.py without adding testrun_functional.py? Forgot an hg add?

Also, we should touch the on-demand listener to execute the correct script name by default.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

testrun_functional.py exists already for a while. We are using it all over the place. If it's not done for your scripts please do ASAP. But I think I have mentioned that explicitly while we were developing the on-demand scripts.

Comment 4

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 569231 [details] [diff] [review]
Patch v1

r+

I get confused by our script names. I don't have a direct dependency on any of the testrun_* scripts. I have a dependency on release_bft.py being in the .../testing which appears to not have changed. That dependency was discussed/agreed upon at the time.

But if release_bft.py changes name, you'll need to make the changes to the listener at that time if it's still in use, or any other dependencies. Our version of "the code must always compile" is "you must make all changes necessary for the system to still run" in one review.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Geo Mealer [:geo] from comment #4)
> But if release_bft.py changes name, you'll need to make the changes to the
> listener at that time if it's still in use, or any other dependencies. Our
> version of "the code must always compile" is "you must make all changes
> necessary for the system to still run" in one review.

The release_bft.py script is not in our repository yet. With undergoing efforts on CI systems we hopefully don't need it anymore. So lets discuss it outside of this bug.

Landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/ee54dca50f5e