Sidebar thumbnails render incorrectly when page is small.

VERIFIED FIXED

Status

Fennec Graveyard
General
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: romaxa, Assigned: wesj)

Tracking

Details

(Whiteboard: [fennec-checkin-postrc])

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Reporter)

Comment 1

7 years ago
Created attachment 518518 [details]
Screenshoot

Open ya.ru in new tab in landscape mode on N900 or android phone  (small size)
check how rendered thumbnail
(Assignee)

Comment 2

7 years ago
Created attachment 518629 [details] [diff] [review]
Patch v1

In these cases the viewport height is actually less than width*ratio here.
Assignee: nobody → wjohnston
Attachment #518629 - Flags: review?(mark.finkle)
Comment on attachment 518629 [details] [diff] [review]
Patch v1

I assume this does not regress any thumbnail behavior.

I'd like to see some automated thumbnail tests for several different cases in a followup bug please.
Attachment #518629 - Flags: review?(mark.finkle) → review+
(Reporter)

Comment 4

7 years ago
yeah, this works great.
Whiteboard: [fennec-checkin-postrc]
(Assignee)

Comment 5

7 years ago
> I'd like to see some automated thumbnail tests for several different cases in a
> followup bug please.

Filed Bug 640957.
(Assignee)

Comment 6

7 years ago
Created attachment 519488 [details] [diff] [review]
Patch v2

I uncovered some different problems here while writing tests.
Attachment #518629 - Attachment is obsolete: true
Attachment #519488 - Flags: review?(mark.finkle)
Attachment #519488 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 7

7 years ago
pushed: http://hg.mozilla.org/mobile-browser/rev/bf44406439b6
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 8

7 years ago
Verified on build: Mozilla /5.0 (Android;Linux armv7l;rv:2.2a1pre)
Gecko/20110406 Firefox/4.2a1pre Fennec /4.1a1pre 
Device: Samsung Captivate (Android 2.2 update 1)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.