640873 - Homepage fails to load 'No recent tabs' in new profiles

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

I found this while viewing the Homepage (about:home) in a new profile. The session store backup file doesn't exist yet, so the file is never loaded, an exception is thrown and the throbber never stops spinning.

This patch adds some sanity checks and always makes sure the throbber is replaced with text. It also bumps down the scheduled delay for updating the add-on cache. 10 seconds was taking forever. Six seconds is a little better, doesn't hurt Ts and we should rarely not have the cache in normal circumstances.

Comment 1

[Matt Brubeck (:mbrubeck)]

Looks good to land for 4.0.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Matt - I'm not sure how frequent this bug would appear to justify landing in Fennec 4. Granted, it is a simple fix, but I just wanted to know more rationale.

Comment 3

[Matt Brubeck (:mbrubeck)]

(In reply to comment #2)
> Matt - I'm not sure how frequent this bug would appear to justify landing in
> Fennec 4. Granted, it is a simple fix, but I just wanted to know more
> rationale.

Oh - I was under the impression this was happening every time about:home was loading in a new profile.  If it's rare, then we can probably wait to land it.  (But if you happened to see it while testing a new profile, it does seem likely that some number of users are seeing it too.)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #3)
> (In reply to comment #2)
> > Matt - I'm not sure how frequent this bug would appear to justify landing in
> > Fennec 4. Granted, it is a simple fix, but I just wanted to know more
> > rationale.
> 
> Oh - I was under the impression this was happening every time about:home was
> loading in a new profile.  If it's rare, then we can probably wait to land it. 
> (But if you happened to see it while testing a new profile, it does seem likely
> that some number of users are seeing it too.)

If the user hits about:home in a new install they'll see this. That might be common. I need to check to see how long it takes the add-on background process to create the cache. Once it's created, this isn't a problem.

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 518653 [details] [diff] [review]
patch

low risk.  first impressions without this sort of suck.

Comment 6

[Matt Brubeck (:mbrubeck)]

If you press the big "Browse" button on about:firstrun, then you get an about:home page with a loading spinner (in the tabs section) that never goes away.  This is especially bad because about:home stays open in its own tab as you open other pages, so users will keep seeing it for the rest of that first browsing session.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/6b93fd7423c4

Comment 8

[Ayan Shah[:ashah]]

Verified:

Mozilla/5.0 (Android; Linux armv71; rv2.0b13pre) Gecko/20110317
Firefox/4.0b13pre Fennec/4.0b6pre