640951 - Status panel border is corrupt when shown over a windowed plugin

Status: RESOLVED WORKSFORME

(Core :: Widget: Win32, defect)

Description

[Jim Mathies [:jimm]]

Attachment: screen shot

Not sure if this is a layout or widget bug. I was under the impression the status panel wasn't it's own window, in which case I'm not even sure how this is being rendered properly. Regardless, the border around the panel is not getting rendered correctly in this case.

Comment 1

[Jim Mathies [:jimm]]

Attachment: test case

Comment 2

[Jim Mathies [:jimm]]

I'm guessing maybe we clip the child so that the status panel underneath is visible? That would explain the messed up border.

Comment 3

[Timothy Nikkel (:tnikkel)]

That status panel isn't its own widget. It is above the plugin, but because the plugin has a widget where ever it is not clipped it will show above everything else in our window. So we make all chrome display items opaque when determining the clip region of the plugin window so that they are visible (http://hg.mozilla.org/mozilla-central/rev/d01932e9114e). This was originally for tab-modal dialogs, so that a plugin wouldn't show through the effect drawn over the whole page with a tab-modal dialog up. There was no status panel when this was designed.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

What's corrupt? Just that white corner?

There's not much we can do about this. If the status panel was perfectly rectangular it would look OK, maybe we should do that.

Comment 5

[Jim Mathies [:jimm]]

(In reply to comment #4)
> What's corrupt? Just that white corner?
> 
> There's not much we can do about this. If the status panel was perfectly
> rectangular it would look OK, maybe we should do that.

Yes. I was thinking the best fix would be to replace the panel with an actual child window (like a tooltip).

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

That would be a bit scary and add overhead. I'd prefer to just leave this alone or make the status panel perfectly rectangular.