Various clean-ups to nsIRadioVisitor and its children

RESOLVED FIXED in mozilla5

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla5
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 518724 [details] [diff] [review]
Patch v1

Mostly changing:
NS_IMETHOD Visitor(nsIFormControl*, PRBool*)
to:
NS_IMETHOD_(bool) Visitor(nsIFormControl*)

Some s/PRBool/bool/ and maybe one or two random changes.
Attachment #518724 - Flags: review?(peterv)
(Assignee)

Comment 1

7 years ago
I wonder if I can actually use NS_IMETHOD_(bool). Let me know if I should use NS_IMETHOD_(PRBool) instead.
(Assignee)

Updated

7 years ago
Whiteboard: [needs review]
Comment on attachment 518724 [details] [diff] [review]
Patch v1

Why do we need |NS_IMETHOD_(bool)| instead of just |virtual bool|?
(Assignee)

Comment 3

7 years ago
(In reply to comment #2)
> Comment on attachment 518724 [details] [diff] [review]
> Patch v1
> 
> Why do we need |NS_IMETHOD_(bool)| instead of just |virtual bool|?

I thought we need to use NS_IMETHOD for public methods in interfaces given that it is adding some things in addition of 'virtual' for some platforms. Am I wrong?

BTW, I should probably change bool to PRBool here. I've heard I shouldn't use that on interface's public methods.
Comment on attachment 518724 [details] [diff] [review]
Patch v1

Just change NS_IMETHOD_(bool) to |virtual PRBool|.
Attachment #518724 - Flags: review?(peterv) → review+
(Assignee)

Updated

7 years ago
Whiteboard: [needs review] → [ready to land][waits for dependencies]
(Assignee)

Comment 5

7 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/9d462cbed60f
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [ready to land][waits for dependencies]
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.