640978 - Various clean-ups to nsIRadioVisitor and its children

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Mostly changing:
NS_IMETHOD Visitor(nsIFormControl*, PRBool*)
to:
NS_IMETHOD_(bool) Visitor(nsIFormControl*)

Some s/PRBool/bool/ and maybe one or two random changes.

Comment 1

[Mounir Lamouri (:mounir)]

I wonder if I can actually use NS_IMETHOD_(bool). Let me know if I should use NS_IMETHOD_(PRBool) instead.

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 518724 [details] [diff] [review]
Patch v1

Why do we need |NS_IMETHOD_(bool)| instead of just |virtual bool|?

Comment 3

[Mounir Lamouri (:mounir)]

(In reply to comment #2)
> Comment on attachment 518724 [details] [diff] [review]
> Patch v1
> 
> Why do we need |NS_IMETHOD_(bool)| instead of just |virtual bool|?

I thought we need to use NS_IMETHOD for public methods in interfaces given that it is adding some things in addition of 'virtual' for some platforms. Am I wrong?

BTW, I should probably change bool to PRBool here. I've heard I shouldn't use that on interface's public methods.

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 518724 [details] [diff] [review]
Patch v1

Just change NS_IMETHOD_(bool) to |virtual PRBool|.

Comment 5

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/9d462cbed60f